Add quick setup script for gh-aw workflows#173
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@copilot looks good, don't include pr-ci-fixer and also let's add a --continuous-improvement flag which also adds a bunch of the best of the continuous improver ones |
|
@strawgate I've opened a new pull request, #180, to work on those changes. Once the pull request is ready, I'll request review from you. |
There was a problem hiding this comment.
Verdict: approve. I found no security, logic, data integrity, performance, or error-handling issues that require changes before merge.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
|
The failing check is Root cause: this is not introduced by this PR’s file changes ( What I ran:
Recommended remediation:
I did not push a fix commit from this run because the required correction is regeneration of files under What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
There was a problem hiding this comment.
Verdict: request changes.
There is a blocking reliability issue that should be fixed before merge.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173
|
CI failed in job Verify compiled workflows (run Root cause: after
Recommended fix:
Validation I ran here:
What is this? | From workflow: PR CI Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
CI failure is from Root cause observed in run
Recommended fix:
Validation performed:
What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
@copilot is this still relevant? any updates we need to make? |
|
@strawgate I've opened a new pull request, #223, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
The failing check is
Recommended fix (minimal):
If those generated changes are not expected for this PR, rebase/merge latest Validation I ran here:
What is this? | From workflow: PR CI Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Failed check is I reproduced locally on this PR branch with Recommended remediation: regenerate and commit the compiled workflow outputs so What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
@coderabbitai what do you think |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🏁 Script executed: Length of output: 6485
✅ What's been implemented well:
📊 Current setup:Default workflows (5):
With
💭 Considerations:The continuous improvement set is quite comprehensive - 16 workflows total when the flag is enabled. This could be a lot of automation for teams new to GitHub Agent Workflows. However, users can always:
Overall, this looks production-ready and addresses the feedback from |
|
CI failed because the workflow compilation check found generated workflow files out of date in this PR branch. What failed
Key log evidence: Root cause
Recommended fix (minimal)On the PR branch ( make compile
git add .github/workflows/
git commit -m "Regenerate compiled workflow lock files"
git pushThis should satisfy the Tests/verification run
What is this? | From workflow: PR CI Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
The failure is in Verify compiled workflows at step Ensure lock files are up to date ( Reproduced locally on branch
Recommended remediation on this PR branch:
I did not push a fix here because the required update is primarily generated workflow artifacts under What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds a new executable quick-setup Bash script and corresponding README sections that automate provisioning recommended GitHub Actions workflows, optionally create/set a COPILOT_GITHUB_TOKEN secret, create a branch, commit/push workflow files, and open a pull request via the GitHub CLI. Script supports workflow selection, continuous-improvement, dry-run, and secret skipping. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Script as quick-setup.sh
participant Git as git
participant GHCLI as gh
participant FS as FileSystem
participant GitHub as GitHub API
User->>Script: run quick-setup (opts)
Script->>Git: ensure repo exists & clean
Script->>GHCLI: verify authentication
GHCLI->>GitHub: validate token
GitHub-->>GHCLI: auth OK
Script->>Script: resolve target repo/branch & workflows
Script->>FS: curl workflow templates
FS-->>Script: return files
Script->>FS: write .github/workflows/*.yml
Script->>GHCLI: create/check COPILOT_GITHUB_TOKEN secret (unless --skip-secret)
GHCLI->>GitHub: set repository secret
Script->>Git: create/checkout branch
Script->>Git: stage & commit changes
Script->>Git: push branch
Git->>GitHub: upload branch
Script->>GHCLI: create pull request
GHCLI->>GitHub: open PR
GitHub-->>User: PR created
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Verdict: approve.
One low-severity documentation inconsistency was noted inline; no blocking issues found.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173
There was a problem hiding this comment.
Verdict: request changes.
Please address the inline medium-severity credential-handling issue before merge.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173
Replace classic token URL with the fine-grained PAT creation page, pre-filling the name, description, and copilot_requests=write account permission. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/quick-setup.sh`:
- Line 237: The current call gh secret set COPILOT_GITHUB_TOKEN --repo "$repo"
--body "$token" exposes the token in process listings; change it to feed the
token via stdin instead (e.g., use printf '%s' "$token" | gh secret set
COPILOT_GITHUB_TOKEN --repo "$repo" --body-file - or another gh option that
reads from stdin) and keep proper quoting/printf to avoid adding a newline;
update the invocation in quick-setup.sh where that command appears (replace the
--body "$token" usage with the piped-stdin approach).
|
/ai please address pr feedback |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Implemented the outstanding credential-handling feedback in
Validation: I pushed commit What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173 |
There was a problem hiding this comment.
Verdict: request changes.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173
|
/ai please address feedback |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Implemented and pushed a fix for the remaining setup-branch feedback in What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/quick-setup.sh`:
- Around line 231-232: The token input currently echoes since the script uses
"read -r token"; change the read call to disable terminal echo (use the -s flag)
so secrets aren't shown as typed and add a newline after input to keep prompt
formatting; update the prompt/behavior around the "printf 'Paste the token here:
'" and the read invocation (the read command referenced as "read -r token") to
use "read -r -s token" and print a newline after to restore normal output.
|
/ai please address feedback |
|
/ai please address feedback |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Implemented the remaining feedback and pushed a follow-up commit to this PR.
What is this? | From workflow: PR Assistant Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #173 |
Summary
scripts/quick-setup.shto bootstrap GitHub Agent Workflows in a target repotrigger-*.ymlfiles plusagentics-maintenance.yml, setsCOPILOT_GITHUB_TOKEN, creates a branch, pushes, and opens a PRREADME.mdandgh-agent-workflows/README.mdTesting
make lintRefs #140
Summary by CodeRabbit
New Features
Documentation