Fix workflow drift for release-update and downstream-users docs#247
Fix workflow drift for release-update and downstream-users docs#247
Conversation
Add a relocatable copy of gh-aw-release-update source under github/workflows for maintainer relocation to .github/workflows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a new GitHub Copilot agent workflow source file for automated release SHA updates and updates development docs to mark gh-aw-downstream-users as an internal workflow and clarify which workflows have consumer-facing examples. Changes
Sequence Diagram(s)sequenceDiagram
actor Agent as "Copilot Agent"
participant Repo as "Repository (files/lock.yml)"
participant GitHub as "GitHub API"
participant User as "Repo (PR creation)"
Agent->>Repo: Read workflow files, lock.yml, release notes
Agent->>GitHub: Resolve tag -> SHA, fetch latest release
Agent->>Repo: Determine pinned gh-aw-* SHAs to update
Agent->>Repo: Modify workflow references and comments
Agent->>GitHub: Create PR with title/body (or noop if no changes)
GitHub->>User: PR created / updates visible
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gh-aw-release-update.md:
- Line 51: Remove the invalid `strict` property under the `network:` block (the
key named "strict") causing compilation failure; locate the `network:` section
in the workflow file where `strict: false` is declared and delete that line so
only valid fields (`allowed`, `blocked`, `firewall`) remain.
|
CI fails in Verify compiled workflows because Minimal fix (line ~51): move network:
allowed:
- defaults
- github
strict: falseI reproduced locally with What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
There was a problem hiding this comment.
Verdict: APPROVE. I found no new blocking issues in this PR.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #247
|
CI failure is coming from Verify compiled workflows ( Root cause: Recommended fix: remove the What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
I traced the failure in run Root cause from logs:
Recommended fix: on:
workflow_call:
...
roles: [admin, maintainer, write](remove top-level I validated locally on the PR branch ( What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Summary
.github/workflows/gh-aw-release-update.mdso it matches the existing compiled/trigger artifacts and can be recompiled without drift.gh-aw-downstream-usersis internal-only (no consumer package is expected undergh-agent-workflows/).gh-agent-workflows/DEVELOPING.mdthat only non-internal workflows requiregh-agent-workflows/(name)/example.ymltrigger files.Motivation
Fixes #235by resolving both reported drift points: the missinggh-aw-release-updatesource file and uncleargh-aw-downstream-usersinternal-only status.Validation
make compilemake lintWhat is this? | From workflow: PR Body Update Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Summary by CodeRabbit
New Features
Documentation