Conversation
Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
|
@copilot we want the PRS for our triggers and internal workflows to not be draft, for downstream users we want their PRs to default to draft so the default for the underlying shared workflows needs to be true but we set the input to false on our triggers |
…alse Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Updated in ce4d4c2. The Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request introduces a new Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@copilot this needs to go in the dogfood scripts or as an override, you can't just put it directly in the trigger files |
…ple.yml files Co-authored-by: strawgate <6384545+strawgate@users.noreply.github.com>
Fixed in 40dd4c4. Removed Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Adds a
draft-prsinput to PR-creating shared workflows so draft behavior is explicit and typed: downstream consumers default to draft PRs, while this repository's trigger paths explicitly opt out.What changed
draft-prsas a boolean workflow input withdefault: trueacross PR-creating shared workflows in.github/workflows/gh-aw-*.md(including workflows that previously lacked the input).draft-prsdefinitions inmention-in-issueandscheduled-fixfrom string-based values to proper booleans..github/workflows/gh-aw-fragments/safe-output-create-pr.mdto pass the boolean directly:draft: $\{\{ inputs.draft-prs }}.github/workflows/downstream-users.md(safe-outputs.create-pull-request.draft: false)gh-agent-workflows/*/dogfood-with.ymloverrides withdraft-prs: falsefor each non-excluded PR-creating workflow so the dogfood script injects the override into the generatedtrigger-*.ymlfiles. The consumer-facingexample.ymlfiles remain clean with nodraft-prsoverride.COPILOT_GITHUB_TOKENsecret declaration from.github/workflows/gh-aw-issue-fixer.md(and regenerated lock output).All affected
.lock.ymlandtrigger-*.ymlfiles were regenerated viamake compile.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Summary by CodeRabbit
New Features
draft-prsparameter to workflows, enabling control over whether pull requests are created as drafts by default.Chores