Skip to content

Add close-older-key to all workflows with title-prefix#703

Merged
strawgate merged 2 commits intomainfrom
feat/close-older-key-from-title-prefix
Mar 15, 2026
Merged

Add close-older-key to all workflows with title-prefix#703
strawgate merged 2 commits intomainfrom
feat/close-older-key-from-title-prefix

Conversation

@strawgate
Copy link
Collaborator

@strawgate strawgate commented Mar 15, 2026

Summary

1. Add close-older-key to all workflows with title-prefix (31 files)

Sets close-older-key from the title-prefix input on every workflow that creates issues, leveraging github/gh-aw#21076. This gives deterministic close-older deduplication that won't collide when multiple caller workflows share the same reusable workflow.

  • For workflows with a dynamic ${{ inputs.title-prefix }} input (26 files + 1 fragment), sets close-older-key: "${{ inputs.title-prefix }}".
  • For internal workflows with hardcoded title-prefix and an input (workflow-patrol, upgrade-check), uses ${{ inputs.title-prefix }}.
  • For internal workflows with hardcoded title-prefix and no input (agent-efficiency, agent-deep-dive), uses the literal key directly.

2. Switch runtime setup to built-in runtimes: with if: conditions (1 file, 61 lock files)

Replaces 48 lines of manual actions/setup-* steps in runtime-setup.md with the compiler's native runtimes: key and if: conditionals (github/gh-aw#16615). The compiler now handles action pinning, version management, and uv workspace exposure. The Copilot CLI config and AGENTS.md fetch steps are retained as custom steps.

Test plan

  • make compile succeeds (only pre-existing mention-in-pr expression-size errors)
  • Lock files include close_older_key in handler config
  • Lock files include conditional runtime setup steps with proper if: expressions and pinned action SHAs

Sets close-older-key from the title-prefix input on every workflow that
creates issues, giving deterministic deduplication that won't collide
when multiple caller workflows share a reusable workflow.

Requires a compiler bump to a gh-aw version that includes
github/gh-aw#21076 (close-older-key support).

Made-with: Cursor
@github-actions github-actions bot added the medium_boom Medium PR blast radius; likely benefits from human review label Mar 15, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Adds a new key close-older-key under safe-outputs.create-issue across many GitHub Actions workflow and lock files (value is either a static workflow identifier or inputs.title-prefix). Also bumps gh-aw setup action references (v0.58.1 → v0.58.3) and Makefile GH_AW_VERSION/GH_AW_BUILD_VERSION, adds GH_HOST: github.com to Copilot CLI install steps, and updates several agent artifact names to use the activation artifact_prefix. No changes to core control flow or error handling in the workflows.

Possibly related PRs

Suggested labels

big_boom

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/close-older-key-from-title-prefix
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md:
- Line 85: The workflow uses the unsupported key close-older-key which was added
after gh-aw v0.58.3; either remove or conditionally gate this key until a gh-aw
release including that feature is used, or update the action version to one that
contains the merge. Locate the line containing close-older-key in the workflow
and either (A) revert to a supported alternative key/value (or omit the entry)
or (B) change the gh-aw action/version pin to the released version that includes
the close-older-key feature so the config won't be ignored or fail at compile
time.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4420322a-8b11-4e7f-8741-fa5e3abc8a79

📥 Commits

Reviewing files that changed from the base of the PR and between 5c3bbdc and 9afd2be.

📒 Files selected for processing (31)
  • .github/workflows/agent-deep-dive.md
  • .github/workflows/agent-efficiency.md
  • .github/workflows/gh-aw-agent-suggestions.md
  • .github/workflows/gh-aw-branch-actions-detective.md
  • .github/workflows/gh-aw-breaking-change-detector.md
  • .github/workflows/gh-aw-bug-hunter.md
  • .github/workflows/gh-aw-code-complexity-detector.md
  • .github/workflows/gh-aw-code-duplication-detector.md
  • .github/workflows/gh-aw-code-quality-audit.md
  • .github/workflows/gh-aw-docs-patrol.md
  • .github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md
  • .github/workflows/gh-aw-estc-docs-patrol-external.md
  • .github/workflows/gh-aw-estc-newbie-contributor-patrol-external.md
  • .github/workflows/gh-aw-flaky-test-investigator.md
  • .github/workflows/gh-aw-fragments/safe-output-scheduled-audit-issue.md
  • .github/workflows/gh-aw-framework-best-practices.md
  • .github/workflows/gh-aw-information-architecture.md
  • .github/workflows/gh-aw-internal-gemini-cli-web-search.md
  • .github/workflows/gh-aw-internal-gemini-cli.md
  • .github/workflows/gh-aw-newbie-contributor-patrol.md
  • .github/workflows/gh-aw-performance-profiler.md
  • .github/workflows/gh-aw-product-manager-impersonator.md
  • .github/workflows/gh-aw-project-summary.md
  • .github/workflows/gh-aw-refactor-opportunist.md
  • .github/workflows/gh-aw-stale-issues-investigator.md
  • .github/workflows/gh-aw-test-coverage-detector.md
  • .github/workflows/gh-aw-text-auditor.md
  • .github/workflows/gh-aw-ux-design-patrol.md
  • .github/workflows/internal-downstream-health.md
  • .github/workflows/upgrade-check.md
  • .github/workflows/workflow-patrol.md

create-issue:
max: 1
title-prefix: "${{ inputs.title-prefix }} "
close-older-key: "${{ inputs.title-prefix }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

Which released version of github/gh-aw first includes support for safe-outputs.create-issue.close-older-keyfrom PR#21076, and is commit 12a6436 included in that release?

💡 Result:

No released version includes safe-outputs.create-issue.close-older-key yet.

  • PR #21076 (“feat: support explicit custom key for close-older matching”) was merged on March 15, 2026, and the support lands in commit 12a6436. [1], [2]
  • The latest published release on the repo release page is v0.58.3 (published March 15, 2026 04:08), and comparing v0.58.3...12a6436 shows additional commits (i.e., 12a6436 is after the release tag), so 12a6436 is not included in v0.58.3. [3], [4]

So, the first release that includes the feature will be the next release after v0.58.3, and commit 12a6436 will be included once that next release is cut. [3], [4]

Sources
[1] github/gh-aw#21076
[2] github/gh-aw@12a6436
[3] https://github.com/github/gh-aw/releases
[4] github/gh-aw@v0.58.3...12a6436


Blocker: close-older-key not yet available in a released version of gh-aw.

Line 85 is correct in intent, but this key requires support from a feature merged after v0.58.3 (the latest release). Merging before a new gh-aw release that includes this feature risks compile failure or the config being ignored in generated lockfiles.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md at
line 85, The workflow uses the unsupported key close-older-key which was added
after gh-aw v0.58.3; either remove or conditionally gate this key until a gh-aw
release including that feature is used, or update the action version to one that
contains the merge. Locate the line containing close-older-key in the workflow
and either (A) revert to a supported alternative key/value (or omit the entry)
or (B) change the gh-aw action/version pin to the released version that includes
the close-older-key feature so the config won't be ignored or fail at compile
time.

@strawgate strawgate merged commit aa4d10c into main Mar 15, 2026
23 of 24 checks passed
@strawgate strawgate deleted the feat/close-older-key-from-title-prefix branch March 15, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

medium_boom Medium PR blast radius; likely benefits from human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant