Add close-older-key to all workflows with title-prefix#703
Conversation
Sets close-older-key from the title-prefix input on every workflow that creates issues, giving deterministic deduplication that won't collide when multiple caller workflows share a reusable workflow. Requires a compiler bump to a gh-aw version that includes github/gh-aw#21076 (close-older-key support). Made-with: Cursor
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughAdds a new key Possibly related PRs
Suggested labels
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md:
- Line 85: The workflow uses the unsupported key close-older-key which was added
after gh-aw v0.58.3; either remove or conditionally gate this key until a gh-aw
release including that feature is used, or update the action version to one that
contains the merge. Locate the line containing close-older-key in the workflow
and either (A) revert to a supported alternative key/value (or omit the entry)
or (B) change the gh-aw action/version pin to the released version that includes
the close-older-key feature so the config won't be ignored or fail at compile
time.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4420322a-8b11-4e7f-8741-fa5e3abc8a79
📒 Files selected for processing (31)
.github/workflows/agent-deep-dive.md.github/workflows/agent-efficiency.md.github/workflows/gh-aw-agent-suggestions.md.github/workflows/gh-aw-branch-actions-detective.md.github/workflows/gh-aw-breaking-change-detector.md.github/workflows/gh-aw-bug-hunter.md.github/workflows/gh-aw-code-complexity-detector.md.github/workflows/gh-aw-code-duplication-detector.md.github/workflows/gh-aw-code-quality-audit.md.github/workflows/gh-aw-docs-patrol.md.github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md.github/workflows/gh-aw-estc-docs-patrol-external.md.github/workflows/gh-aw-estc-newbie-contributor-patrol-external.md.github/workflows/gh-aw-flaky-test-investigator.md.github/workflows/gh-aw-fragments/safe-output-scheduled-audit-issue.md.github/workflows/gh-aw-framework-best-practices.md.github/workflows/gh-aw-information-architecture.md.github/workflows/gh-aw-internal-gemini-cli-web-search.md.github/workflows/gh-aw-internal-gemini-cli.md.github/workflows/gh-aw-newbie-contributor-patrol.md.github/workflows/gh-aw-performance-profiler.md.github/workflows/gh-aw-product-manager-impersonator.md.github/workflows/gh-aw-project-summary.md.github/workflows/gh-aw-refactor-opportunist.md.github/workflows/gh-aw-stale-issues-investigator.md.github/workflows/gh-aw-test-coverage-detector.md.github/workflows/gh-aw-text-auditor.md.github/workflows/gh-aw-ux-design-patrol.md.github/workflows/internal-downstream-health.md.github/workflows/upgrade-check.md.github/workflows/workflow-patrol.md
| create-issue: | ||
| max: 1 | ||
| title-prefix: "${{ inputs.title-prefix }} " | ||
| close-older-key: "${{ inputs.title-prefix }}" |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
Which released version of github/gh-aw first includes support for safe-outputs.create-issue.close-older-keyfrom PR#21076, and is commit 12a6436 included in that release?
💡 Result:
No released version includes safe-outputs.create-issue.close-older-key yet.
- PR #21076 (“feat: support explicit custom key for close-older matching”) was merged on March 15, 2026, and the support lands in commit
12a6436. [1], [2] - The latest published release on the repo release page is v0.58.3 (published March 15, 2026 04:08), and comparing
v0.58.3...12a6436shows additional commits (i.e.,12a6436is after the release tag), so12a6436is not included in v0.58.3. [3], [4]
So, the first release that includes the feature will be the next release after v0.58.3, and commit 12a6436 will be included once that next release is cut. [3], [4]
Sources
[1] github/gh-aw#21076
[2] github/gh-aw@12a6436
[3] https://github.com/github/gh-aw/releases
[4] github/gh-aw@v0.58.3...12a6436
Blocker: close-older-key not yet available in a released version of gh-aw.
Line 85 is correct in intent, but this key requires support from a feature merged after v0.58.3 (the latest release). Merging before a new gh-aw release that includes this feature risks compile failure or the config being ignored in generated lockfiles.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/gh-aw-estc-actions-resource-not-accessible-detector.md at
line 85, The workflow uses the unsupported key close-older-key which was added
after gh-aw v0.58.3; either remove or conditionally gate this key until a gh-aw
release including that feature is used, or update the action version to one that
contains the merge. Locate the line containing close-older-key in the workflow
and either (A) revert to a supported alternative key/value (or omit the entry)
or (B) change the gh-aw action/version pin to the released version that includes
the close-older-key feature so the config won't be ignored or fail at compile
time.
Summary
1. Add
close-older-keyto all workflows with title-prefix (31 files)Sets
close-older-keyfrom thetitle-prefixinput on every workflow that creates issues, leveraging github/gh-aw#21076. This gives deterministic close-older deduplication that won't collide when multiple caller workflows share the same reusable workflow.${{ inputs.title-prefix }}input (26 files + 1 fragment), setsclose-older-key: "${{ inputs.title-prefix }}".workflow-patrol,upgrade-check), uses${{ inputs.title-prefix }}.agent-efficiency,agent-deep-dive), uses the literal key directly.2. Switch runtime setup to built-in
runtimes:withif:conditions (1 file, 61 lock files)Replaces 48 lines of manual
actions/setup-*steps inruntime-setup.mdwith the compiler's nativeruntimes:key andif:conditionals (github/gh-aw#16615). The compiler now handles action pinning, version management, and uv workspace exposure. The Copilot CLI config and AGENTS.md fetch steps are retained as custom steps.Test plan
make compilesucceeds (only pre-existingmention-in-prexpression-size errors)close_older_keyin handler configif:expressions and pinned action SHAs