Added support for overwriting the service version per classloader

[tobiasstadler]

What does this PR do?

Fixes #1725

Checklist

• This is an enhancement of existing features, or a new feature in existing plugins
  • I have updated CHANGELOG.asciidoc
  • I have added tests that prove my fix is effective or that my feature works
  • Added an API method or config option? Document in which version this will be introduced
  • I have made corresponding changes to the documentation
• This is a bugfix
  • I have updated CHANGELOG.asciidoc
  • I have added tests that would fail without this fix
• This is a new plugin
  • I have updated CHANGELOG.asciidoc
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced
  • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
• This is something else
  • I have updated CHANGELOG.asciidoc

[ghost]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Reason: null

• Start Time: 2022-01-27T07:15:41.553+0000

• Duration: 48 min 20 sec

• Commit: d76f2a5

Test stats 🧪

Test	Results
Failed	0
Passed	2455
Skipped	16
Total	2471

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run benchmark tests : Run the benchmark tests.

• run jdk compatibility tests : Run the JDK Compatibility tests.

• run integration tests : Run the Agent Integration tests.

• run end-to-end tests : Run the APM-ITs.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[tobiasstadler]

@felixbarny Is there any chance to get this merged?

[felixbarny]

I'm out for a bit, will leave this to the team to decide.

[tobiasstadler]

Ok, Thank you for the info.

@SylvainJuge @eyalkoren What is your opinion?

[SylvainJuge]

FYI, I will also be off for a couple of weeks.

From what I recall we previously agreed that fixing that more generally would be a better option (#1327), while it's not without challenges, especially when relying on packaging conventions, I think it would probably a better option to solve the general case.

[tobiasstadler]

@SylvainJuge It would be great if #1327 is supported, but as far as I know nobody is working on this. I also think that #1327 can build in this PR.

[tobiasstadler]

@SylvainJuge If this was merged I could use it in https://github.com/tobiasstadler/apm-wildfly-deployment-plugin to set the service version (in addition to the service name)

[tobiasstadler]

@SylvainJuge / @felixbarny Any News?

[SylvainJuge]

Hi @tobiasstadler, we have added this to our short-term backlog.
While we can't provide guarantees nor ETA, we will try to handle it soon.

[tobiasstadler]

Any chance this will make it into 1.29.0?

[felixbarny]

After merging and consolidating with #1922, I don't have objections to this PR.

[tobiasstadler]

I will use ServiceInfo instead of ServiceNameAndVersion once #1922 is merged.

[felixbarny]

run elasticsearch-ci/docs

[felixbarny]

Thanks for the contribution and for gently pushing for it ❤️

[felixbarny]

run elasticsearch-ci/docs

[tobiasstadler]

Thank you very much!