Use Implementation-Version as default service version if it is available#1922
Use Implementation-Version as default service version if it is available#1922felixbarny merged 42 commits intoelastic:mainfrom
Conversation
cf08453 to
4ac6672
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
|
Could someone please have a look? |
|
@SylvainJuge Maybe you can spare some time please |
|
@felixbarny Maybe you can spare some time please? |
|
Hi @tobiasstadler, we have added this to our short-term backlog. |
|
Thank You! I am looking forward to it. |
|
Any chance this will make it into 1.29.0? |
felixbarny
left a comment
There was a problem hiding this comment.
Good improvement and fits will with the just merged implementation-title detection. Let's refactor the code a bit and I think we're good to go.
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/ServiceVersionUtil.java
Outdated
Show resolved
Hide resolved
apm-agent-core/src/main/java/co/elastic/apm/agent/configuration/ServiceVersionUtil.java
Outdated
Show resolved
Hide resolved
|
/elasticsearch-ci/docs |
felixbarny
left a comment
There was a problem hiding this comment.
I took the liberty to push some polishing changes
|
run elasticsearch-ci/docs |
Head branch was pushed to by a user without write access
|
@felixbarny Would you please run elasticsearch-ci/docs again? |
|
run elasticsearch-ci/docs |
|
Thank You! |
What does this PR do?
When the MANIFEST.MF of main jar contains the Implementation-Version attribute, it is used as the default service version (except for application servers).
Checklist