Skip to content

Added an integration test for retrieving the service name/version from the main jars manifest#2190

Merged
felixbarny merged 12 commits intoelastic:mainfrom
tobiasstadler:main-app-test
Jan 27, 2022
Merged

Added an integration test for retrieving the service name/version from the main jars manifest#2190
felixbarny merged 12 commits intoelastic:mainfrom
tobiasstadler:main-app-test

Conversation

@tobiasstadler
Copy link
Contributor

@tobiasstadler tobiasstadler commented Oct 13, 2021 •
edited by zube bot
Loading

What does this PR do?

Integration test for #1921 and #1922

Checklist

@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Oct 13, 2021

I don't think this needs an entry in the changelog

@github-actions github-actions bot added agent-java community Issues and PRs created by the community triage labels Oct 13, 2021
@ghost
Copy link

ghost commented Oct 13, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-27T07:43:46.860+0000

  • Duration: 49 min 3 sec

  • Commit: 4c83ac2

Test stats 🧪

Test Results
Failed 0
Passed 2452
Skipped 16
Total 2468

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tobiasstadler tobiasstadler changed the title Added an integration test for retrieving the service name/version fro…m the main jars manifest Added an integration test for retrieving the service name/version from the main jars manifest Oct 14, 2021
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jan 26, 2022

@felixbarny Since #1921 and #1922 are now merged, you might consider merging this

@felixbarny
Remove Java 7 test
4c83ac2 
- makes the test simpler
- The Java 7 test doesn't run properly on Apple Silicon
- Testing 8, 11, and 17 gives me enough confidence that this works
@felixbarny felixbarny enabled auto-merge (squash) January 27, 2022 07:45
@felixbarny
Copy link
Member

felixbarny commented Jan 27, 2022

run elasticsearch-ci/docs

@felixbarny felixbarny merged commit 5d30f89 into elastic:main Jan 27, 2022
@tobiasstadler tobiasstadler deleted the main-app-test branch January 27, 2022 08:33
@tobiasstadler
Copy link
Contributor Author

tobiasstadler commented Jan 27, 2022

Thank You!

@felixbarny
Copy link
Member

felixbarny commented Jan 27, 2022

Thank you too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixbarny felixbarny felixbarny approved these changes

Assignees

No one assigned

Labels

agent-java community Issues and PRs created by the community triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasstadler @felixbarny