fix: clippy::wrong_self_convention warning for fields with is_ prefix etc.#349
Merged
Veetaha merged 1 commit intoelastio:masterfrom Oct 8, 2025
Merged
fix: clippy::wrong_self_convention warning for fields with is_ prefix etc.#349Veetaha merged 1 commit intoelastio:masterfrom
clippy::wrong_self_convention warning for fields with is_ prefix etc.#349Veetaha merged 1 commit intoelastio:masterfrom
Conversation
Veetaha
approved these changes
Oct 8, 2025
Collaborator
Veetaha
left a comment
There was a problem hiding this comment.
Makes sense, thanks! I'll make a patch
Merged
Collaborator
|
Released in 3.8.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When having a field which has one of the prefixes listed by
clippy::wrong_self_conventionyou will end up getting said lint warning in yourbon::Buildermacro:This PR proposes to add
#[allow(clippy::wrong_self_convention)]to all generated setters to avoid this lint warning entirely.