Skip to content

fix: clippy::wrong_self_convention warning for fields with is_ prefix etc. #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veetaha merged 1 commit into from
Oct 8, 2025
Merged

fix: clippy::wrong_self_convention warning for fields with is_ prefix etc. #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bon-macros/src/builder/builder_gen/setters/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,10 @@ impl<'a> SettersCtx<'a> {
// your design of this setter already went wrong.
clippy::impl_trait_in_params,
clippy::missing_const_for_fn,
// When having a field which has one of the prefixes listed by
// `clippy::wrong_self_convention` you will end up getting said lint
// warning in your `bon::Builder` because we take self by value.
clippy::wrong_self_convention,
)]
#[inline(always)]
#(#fn_modifiers)* fn #name(#maybe_mut #self_, #( #pats: #types ),*) -> #return_type
Expand Down
Loading