Fixing Android 12 url deeplinks by ouchadam · Pull Request #6225 · element-hq/element-android

ouchadam · 2022-06-01T15:34:21Z

Draft as this relies on a element.io change which is tracked by this Ops request, https://github.com/vector-im/sre-internal/issues/1382 (internal link)

Fixes #5748

Type of change

Feature
Bugfix
Technical
Other :

Content

Fixes matrix-org/matrix-ansible-private#5748 Android 12 being ineligible for URL deeplinks

Creates a separate intent-filter to enable the required autoVerify on the *.element.io urls

See verify site for more details

Motivation and context

To fix missing Android 12 URL deeplink

Screenshots / GIFs

// TODO relies on element.io's assetlinks.json to be updated

Tests

Follow steps in matrix-org/matrix-ansible-private#5748

or to manually check the verification...

Using an Android 12 emulator

Ensure links verification is enabled

adb shell am compat enable 175408749 im.vector.app.debug

Reset link verifications for the given package id

adb shell pm set-app-links --package im.vector.app.debug 0 all

Force the package id links to be verifed

adb shell pm verify-app-links --re-verify im.vector.app.debug

Print the link verification of the package id

adb shell pm get-app-links im.vector.app.debug

  im.vector.app.debug:
    ID: 09a2698b-f577-4f38-a4a0-225af2aba897
    Signatures: [B0:B0:51:DC:56:5C:81:2F:E1:7F:6F:3E:94:5B:4D:79:04:71:23:AB:0D:A6:12:86:76:9E:B2:94:91:97:13:0E]
    Domain verification state:
      *.element.io: verified

Trigger a url

adb shell am start -a android.intent.action.VIEW -c android.intent.category.BROWSABLE -d "https://mobile.element.io/?hs_url=https%3A%2F%2Fmatrix-client.matrix.org%2F&is_url=https%3A%2F%2Fvec
tor.im%2F"

Tested devices

Physical
Emulator
OS version(s):

github-actions · 2022-06-01T16:13:47Z

Unit Test Results

146 files ±0 146 suites ±0 2m 33s ⏱️ +26s
236 tests ±0 236 ✔️ ±0 0 💤 ±0 0 ❌ ±0
788 runs ±0 788 ✔️ ±0 0 💤 ±0 0 ❌ ±0

Results for commit c7f9126. ± Comparison against base commit e18146a.

ouchadam · 2022-06-01T16:21:21Z

Added blocked label whilst the element.io repo pull request is under review

bmarty

LGTM, hence I do not see the PR to update element.io website anymore (to see if it's been merged and deployed).

ouchadam · 2022-07-04T13:06:12Z

LGTM, hence I do not see the PR to update element.io website anymore (to see if it's been merged and deployed).

it's been replaced with an OPS ticket (was recommended in the tech internal room)

…nks.json`) Fix https://github.com/matrix-org/matrix-ansible-private/issues/5223 which unblocks element-hq/element-android#6225 to solve element-hq/element-android#5748

…nks.json`) (#1431) Add Android asset links to support app intents (opening `app.element.io` will open the Android app when installed): `/.well-known/assetlinks.json` Fix https://github.com/matrix-org/matrix-ansible-private/issues/5223 which unblocks element-hq/element-android#6225 to solve element-hq/element-android#5748

MadLittleMods · 2022-09-12T22:00:11Z

+                <category android:name="android.intent.category.BROWSABLE" />
+
+                <data android:scheme="https" />
                <data android:host="app.element.io" />


LGTM, hence I do not see the PR to update element.io website anymore (to see if it's been merged and deployed).

This is now unblocked as I've added https://element.io/.well-known/assetlinks.json via https://github.com/vector-im/element.io-website/pull/96

thanks for the update! will rebase this PR

- urls must be verified in order for deeplinks to be enabled by the system

ElementBot · 2022-09-13T08:53:07Z

	Warnings
⚠️	vector/src/main/AndroidManifest.xml#L197 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L197 - Attribute `autoVerify` is only used in API level 23 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L225 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L225 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L228 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L228 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion
⚠️	vector/src/main/AndroidManifest.xml#L282 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L282 - Expecting `android:screenOrientation="unspecified"` or `"fullSensor"` for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices
⚠️	vector/src/main/AndroidManifest.xml#L291 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L291 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L298 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L298 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L304 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L304 - Attribute `supportsPictureInPicture` is only used in API level 24 and higher (current min is 21)
⚠️	vector/src/main/AndroidManifest.xml#L420 - Exported receiver does not require permission
⚠️	vector/src/main/AndroidManifest.xml#L420 - Exported receiver does not require permission

Generated by 🚫 dangerJS against 4e068a1

…tead of all subs

ouchadam · 2022-09-13T11:39:38Z

+                <category android:name="android.intent.category.BROWSABLE" />
+
+                <data android:scheme="https" />
+                <data android:host="*.element.io" />


captures all subdomains of element.io to avoid needing to host a assetlinks.json on every subdomain

sonarqubecloud · 2022-09-13T12:43:59Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

ouchadam · 2022-09-14T17:06:22Z

converting back to draft, we'll need to create a list of all the deeplinks we support in order to know which domains to host the assetlinks.json

AndrewBedscastle · 2023-04-07T15:30:05Z

Any progress on this?

I'd be extremely helpful to send inexperienced users to the app / correct room without telling them they need to approve the custom link schema at the app's settings screen (by doing this it also works on Android 12+)

At least the app.element.io scheme should work on Android 12+
I'd be happy to help but this can only be fixed by the play console admin / domain holder

bmarty · 2024-05-02T14:49:17Z

OK, it's working, let's merge this.

sbeach92 · 2024-09-18T18:30:28Z

#8850 Undoes this fix, as mobile.element.io url is now missing

ouchadam added the X-Blocked label Jun 1, 2022

bmarty approved these changes Jul 4, 2022

View reviewed changes

MadLittleMods mentioned this pull request Sep 2, 2022

Configure link to define custom homeserver/identity server automatically from https://app.element.io/mobile_guide/ does not work (mobile.element.io) #5748

Closed

MadLittleMods mentioned this pull request Sep 7, 2022

Add Android asset links to support app intents (/.well-known/assetlinks.json) matrix-org/matrix.org#1431

Merged

ouchadam mentioned this pull request Sep 12, 2022

App stuck on first screen if it can't connect to matrix.org server #7078

Open

MadLittleMods reviewed Sep 12, 2022

View reviewed changes

MadLittleMods removed the X-Blocked label Sep 12, 2022

MadLittleMods assigned ouchadam Sep 12, 2022

adding android 12 url deeplink support

af59f65

- urls must be verified in order for deeplinks to be enabled by the system

ouchadam marked this pull request as ready for review September 13, 2022 08:50

ouchadam force-pushed the feature/adm/android-12-deeplinks branch from c7f9126 to af59f65 Compare September 13, 2022 08:50

capture all element subdomains, means we can verify on the parent ins…

4e068a1

…tead of all subs

ouchadam commented Sep 13, 2022

View reviewed changes

ouchadam marked this pull request as draft September 14, 2022 17:05

bmarty marked this pull request as ready for review May 2, 2024 14:49

bmarty merged commit 305372c into develop May 2, 2024

bmarty deleted the feature/adm/android-12-deeplinks branch May 2, 2024 14:58

arinc9 mentioned this pull request Sep 16, 2024

Link to define custom homeserver/identity server automatically from https://app.element.io/mobile_guide/ does not work on Android 14 #8904

Closed

Conversation

ouchadam commented Jun 1, 2022 • edited by omame Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Uh oh!

github-actions Bot commented Jun 1, 2022

Unit Test Results

Uh oh!

ouchadam commented Jun 1, 2022

Uh oh!

bmarty left a comment

Choose a reason for hiding this comment

Uh oh!

ouchadam commented Jul 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MadLittleMods Sep 12, 2022

Choose a reason for hiding this comment

Uh oh!

ouchadam Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

ElementBot commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ouchadam Sep 13, 2022

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Sep 13, 2022

Uh oh!

ouchadam commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndrewBedscastle commented Apr 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmarty commented May 2, 2024

Uh oh!

sbeach92 commented Sep 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ouchadam commented Jun 1, 2022 •

edited by omame

Loading

ouchadam commented Jul 4, 2022 •

edited

Loading

ElementBot commented Sep 13, 2022 •

edited

Loading

ouchadam commented Sep 14, 2022 •

edited

Loading

AndrewBedscastle commented Apr 7, 2023 •

edited

Loading