Skip to content

Replace *.element.io deep link with actual hosts#8850

Merged
bmarty merged 2 commits into
developfrom
fix/jme/8894-ea-intercepts-mas-urls
Jun 25, 2024
Merged

Replace *.element.io deep link with actual hosts#8850
bmarty merged 2 commits into
developfrom
fix/jme/8894-ea-intercepts-mas-urls

Conversation

@jmartinesp
Copy link
Copy Markdown
Member

@jmartinesp jmartinesp commented Jun 25, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Replace *.element.io deep link with actual hosts.

Motivation and context

Fixes #8849.

Tests

  1. Have EA installed on your device with permission to open links.
  2. Install EXA, try to log into an account using OIDC.
  3. If you can log in normally, it's working.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 14

Checklist

This is done to avoid incorrectly intercepting links in other apps, as Element X Android.
@jmartinesp jmartinesp requested a review from bmarty June 25, 2024 09:57
@ElementBot
Copy link
Copy Markdown

Warnings
⚠️

vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO.

⚠️

vector/src/main/AndroidManifest.xml#L16 - READ_EXTERNAL_STORAGE is deprecated (and is not granted) when targeting Android 13+. If you need to query or interact with MediaStore or media files on the shared storage, you should instead use one or more new storage permissions: READ_MEDIA_IMAGES, READ_MEDIA_VIDEO or READ_MEDIA_AUDIO.

⚠️

vector/src/main/AndroidManifest.xml#L180 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L180 - Attribute autoVerify is only used in API level 23 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L214 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

⚠️

vector/src/main/AndroidManifest.xml#L214 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

⚠️

vector/src/main/AndroidManifest.xml#L217 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

⚠️

vector/src/main/AndroidManifest.xml#L217 - Consider splitting data tag into multiple tags with individual attributes to avoid confusion

⚠️

vector/src/main/AndroidManifest.xml#L271 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

⚠️

vector/src/main/AndroidManifest.xml#L271 - Expecting android:screenOrientation="unspecified" or "fullSensor" for this activity so the user can use the application in any orientation and provide a great experience on Chrome OS devices

⚠️

vector/src/main/AndroidManifest.xml#L271 - Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed.

⚠️

vector/src/main/AndroidManifest.xml#L271 - Should not restrict activity to fixed orientation. This may not be suitable for different form factors, causing the app to be letterboxed.

⚠️

vector/src/main/AndroidManifest.xml#L280 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L280 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L287 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L287 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L293 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L293 - Attribute supportsPictureInPicture is only used in API level 24 and higher (current min is 21)

⚠️

vector/src/main/AndroidManifest.xml#L416 - Exported receiver does not require permission

⚠️

vector/src/main/AndroidManifest.xml#L416 - Exported receiver does not require permission

Generated by 🚫 dangerJS against 0292749

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EA intercepts any link with *.element.io host, breaking OIDC flow on EXA

3 participants