minor string change in settings tab#20804
Conversation
SimonBrandner
left a comment
There was a problem hiding this comment.
LGTM - thank you for working on this!
turt2live
left a comment
There was a problem hiding this comment.
I'm inclined to keep this as-is until Communities are deleted, at which point we can consider the string (and fix it).
I believe the deletion is planned Soon™, though don't have an exact target date just yet.
|
Hey @turt2live ! If I'm not wrong, there aren't any more changes to be done to the solution right? If not, should I proceed
P.S. apologies for the late reply, i thought the pr would be merged. |
|
It looks like this PR reinserts the shortcuts moved to react-sdk with https://github.com/matrix-org/matrix-react-sdk/pull/7850/files#diff-454f7f431b8bcf5cfe7cdb0a66bc6f123dcf9617f67d7dce3b3d99bbb1fdad64R265-R266 which was merged after this PR was created. You could refer https://github.com/luixxiul/matrix-react-sdk/commit/72fd5215db88ef839a8c815761f5f3a3ea58ae86 if you are still interested, since I don't want to hijack the PR. |

Fixes: #20755
Signed-off-by: Ajeya Bhat ajeyabhat.off@gmail.com
Notes:
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.