Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Replace "community" with "space" of keyboard shortcuts#7994

Merged
t3chguy merged 2 commits into
matrix-org:developfrom
luixxiul:RoomOrSpace
Mar 23, 2022
Merged

Replace "community" with "space" of keyboard shortcuts#7994
t3chguy merged 2 commits into
matrix-org:developfrom
luixxiul:RoomOrSpace

Conversation

@luixxiul
Copy link
Copy Markdown
Contributor

@luixxiul luixxiul commented Mar 5, 2022

Fixes element-hq/element-web#20755
Closes element-hq/element-web#20804

Depends on #8027

Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com

Notes: Replace "community" with "space" of keyboard shortcuts
element-web notes: none


This PR currently has no changelog labels, so will not be included in changelogs.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

Preview: https://pr7994--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Fixes element-hq/element-web#20755
Closes element-hq/element-web#20804

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

@luixxiul
Copy link
Copy Markdown
Contributor Author

luixxiul commented Mar 5, 2022

Waiting for @aj-ya 's response...

@aj-ya
Copy link
Copy Markdown
Contributor

aj-ya commented Mar 5, 2022

Looks good!

@luixxiul luixxiul marked this pull request as ready for review March 5, 2022 18:25
@luixxiul luixxiul requested a review from a team as a code owner March 5, 2022 18:25
Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luixxiul
Copy link
Copy Markdown
Contributor Author

As groups (communities) have been deprecated and removed, it is no longer required to consider them.

Copy link
Copy Markdown
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@t3chguy t3chguy merged commit 9b29442 into matrix-org:develop Mar 23, 2022
@luixxiul luixxiul deleted the RoomOrSpace branch March 23, 2022 07:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove mentions of communities from Keyboard settings tab

4 participants