Skip to content

Fix Build and push complement image CI job not having Poetry for complement.sh#19578

Merged
MadLittleMods merged 5 commits into
developfrom
madlittlemods/fix-complement-push-image-ci-job-poetry
Mar 17, 2026
Merged

Fix Build and push complement image CI job not having Poetry for complement.sh#19578
MadLittleMods merged 5 commits into
developfrom
madlittlemods/fix-complement-push-image-ci-job-poetry

Conversation

@MadLittleMods
Copy link
Copy Markdown
Contributor

@MadLittleMods MadLittleMods commented Mar 17, 2026

Fix Build and push complement image CI job not having Poetry for complement.sh

Build and push complement image, https://github.com/element-hq/synapse/actions/runs/23176317296/job/67339146082

scripts-dev/complement.sh: line 227: poetry: command not found

Follow-up to #19523

This regressed in #19476

Testing strategy

  1. Visit https://github.com/element-hq/synapse/actions/workflows/push_complement_image.yml
  2. Run workflow:
    • Use workflow from: madlittlemods/fix-complement-push-image-ci-job-poetry
    • Branch: develop
  3. Wait for CI to run and pass ✅

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

Comment thread changelog.d/19578.bugfix
@@ -0,0 +1 @@
Fix `Build and push complement image` CI job not having `poetry` available for the Complement runner script.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is actually passing now ✅ : https://github.com/element-hq/synapse/actions/runs/23176910722/job/67341095251 (using the testing strategy from the PR description)

@MadLittleMods MadLittleMods marked this pull request as ready for review March 17, 2026 04:16
@MadLittleMods MadLittleMods requested a review from a team as a code owner March 17, 2026 04:16
Copy link
Copy Markdown
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, modulo the poetry version which just changed

Comment thread .github/workflows/push_complement_image.yml Outdated
MadLittleMods added a commit that referenced this pull request Mar 17, 2026
@MadLittleMods MadLittleMods force-pushed the madlittlemods/fix-complement-push-image-ci-job-poetry branch from f3c4a1e to 25ebe50 Compare March 17, 2026 14:56
@MadLittleMods MadLittleMods merged commit d65ef84 into develop Mar 17, 2026
36 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/fix-complement-push-image-ci-job-poetry branch March 17, 2026 15:51
@MadLittleMods
Copy link
Copy Markdown
Contributor Author

Thanks for the review @sandhose 🦪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants