Fix Build and push complement image CI job not having Poetry for complement.sh#19578
Merged
MadLittleMods merged 5 commits intoMar 17, 2026
Merged
Conversation
MadLittleMods
commented
Mar 17, 2026
| @@ -0,0 +1 @@ | |||
| Fix `Build and push complement image` CI job not having `poetry` available for the Complement runner script. | |||
Contributor
Author
There was a problem hiding this comment.
CI is actually passing now ✅ : https://github.com/element-hq/synapse/actions/runs/23176910722/job/67341095251 (using the testing strategy from the PR description)
sandhose
approved these changes
Mar 17, 2026
Member
sandhose
left a comment
There was a problem hiding this comment.
Fine by me, modulo the poetry version which just changed
MadLittleMods
added a commit
that referenced
this pull request
Mar 17, 2026
f3c4a1e to
25ebe50
Compare
Contributor
Author
|
Thanks for the review @sandhose 🦪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Build and push complement imageCI job not having Poetry forcomplement.sh❌
Build and push complement image, https://github.com/element-hq/synapse/actions/runs/23176317296/job/67339146082Follow-up to #19523
This regressed in #19476
Testing strategy
madlittlemods/fix-complement-push-image-ci-job-poetrydevelopPull Request Checklist
EventStoretoEventWorkerStore.".code blocks.