Fix `Build and push complement image` CI job pointing to non-existent image by MadLittleMods · Pull Request #19523 · element-hq/synapse

MadLittleMods · 2026-03-03T16:36:54Z

As spotted by @reivilibre 🦅 #19475 (comment),

Fix Build and push complement image CI job pointing to non-existent image

❌ Build and push complement image, https://github.com/element-hq/synapse/actions/runs/22609655282/job/65509315002#step:8:39

Error response from daemon: No such image: complement-synapse:latest

Regressed in #19475 (comment) where we updated complement.sh to build localhost/complement-synapse instead of complement-synapse.

This will get the CI passing again on element-hq/synapse-rust-apps as it's currently using an old complement-synapse but new Complement tests which are fixed in the latest Synapse (example failure)

Pull Request Checklist

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct (run the linters)

See #19475 (comment)

MadLittleMods · 2026-03-03T17:11:32Z

          for TAG in ${{ join(fromJson(steps.meta.outputs.json).tags, ' ') }}; do 
            echo "tag and push $TAG"
-            docker tag complement-synapse $TAG
+            docker tag localhost/complement-synapse $TAG


This matches the path we make in complement.sh:

synapse/scripts-dev/complement.sh

Lines 38 to 52 in fd61b8e

# Tag local builds with a dummy registry namespace so that later builds may reference

# them exactly instead of accidentally pulling from a remote registry.

#

# This is important as some storage drivers/types prefer remote images over local

# (`containerd`) which causes problems as we're testing against some remote image that

# doesn't include all of the changes that we're trying to test (be it locally or in a PR

# in CI). This is spawning from a real-world problem where the GitHub runners were

# updated to use Docker Engine 29.0.0+ which uses `containerd` by default for new

# installations.

LOCAL_IMAGE_NAMESPACE=localhost

# The image tags for how these images will be stored in the registry

SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse"

SYNAPSE_WORKERS_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse-workers"

COMPLEMENT_SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/complement-synapse"

See #19475 for more context on why we added localhost

See #19523 (comment)

MadLittleMods · 2026-03-17T02:56:41Z

Thanks for the review @sandhose 🦭

MadLittleMods · 2026-03-17T03:20:04Z

          for TAG in ${{ join(fromJson(steps.meta.outputs.json).tags, ' ') }}; do 
            echo "tag and push $TAG"
+            # `localhost/complement-synapse` should match the image created by `scripts-dev/complement.sh`
            docker tag complement-synapse $TAG


Accidentally reverted the main localhost/complement-synapse change in 7c60c7f before merging 🤦

Restored in c37a5bb

See #19523 (comment)

…omplement.sh` (#19578) ❌ `Build and push complement image`, https://github.com/element-hq/synapse/actions/runs/23176317296/job/67339146082 ``` scripts-dev/complement.sh: line 227: poetry: command not found ``` Follow-up to #19523 This regressed in #19476 ### Testing strategy 1. Visit https://github.com/element-hq/synapse/actions/workflows/push_complement_image.yml 1. **Run workflow**: - **Use workflow from:** `madlittlemods/fix-complement-push-image-ci-job-poetry` - **Branch:** `develop` 1. Wait for CI to run and pass ✅

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [element-hq/synapse](https://github.com/element-hq/synapse) | minor | `v1.149.1` → `v1.150.0` | --- ### Release Notes <details> <summary>element-hq/synapse (element-hq/synapse)</summary> ### [`v1.150.0`](https://github.com/element-hq/synapse/releases/tag/v1.150.0) [Compare Source](element-hq/synapse@v1.149.1...v1.150.0) ### Synapse 1.150.0 (2026-03-24) No significant changes since 1.150.0rc1. ### Synapse 1.150.0rc1 (2026-03-17) #### Features - Add experimental support for the [MSC4370](matrix-org/matrix-spec-proposals#4370) Federation API `GET /extremities` endpoint. ([#19314](element-hq/synapse#19314)) - [MSC4140: Cancellable delayed events](matrix-org/matrix-spec-proposals#4140): When persisting a delayed event to the timeline, include its `delay_id` in the event's `unsigned` section in `/sync` responses to the event sender. ([#19479](element-hq/synapse#19479)) - Expose [MSC4354 Sticky Events](matrix-org/matrix-spec-proposals#4354) over the legacy (v3) /sync API. ([#19487](element-hq/synapse#19487)) - When Matrix Authentication Service (MAS) integration is enabled, allow MAS to set the user locked status in Synapse. ([#19554](element-hq/synapse#19554)) #### Bugfixes - Fix `Build and push complement image` CI job pointing to non-existent image. ([#19523](element-hq/synapse#19523)) - Fix a bug introduced in v1.26.0 that caused deactivated, erased users to not be removed from the user directory. ([#19542](element-hq/synapse#19542)) #### Improved Documentation - In the Admin API documentation, always express path parameters as `/<param>` instead of as `/$param`. ([#19307](element-hq/synapse#19307)) - Update docs to clarify `outbound_federation_restricted_to` can also be used with the [Secure Border Gateway (SBG)](https://element.io/en/server-suite/secure-border-gateways). ([#19517](element-hq/synapse#19517)) - Unify Complement developer docs. ([#19518](element-hq/synapse#19518)) #### Internal Changes - Put membership updates in a background resumable task when changing the avatar or the display name. ([#19311](element-hq/synapse#19311)) - Add in-repo Complement test to sanity check Synapse version matches git checkout (testing what we think we are). ([#19476](element-hq/synapse#19476)) - Migrate `dev` dependencies to [PEP 735](https://peps.python.org/pep-0735/) dependency groups. ([#19490](element-hq/synapse#19490)) - Remove the optional `systemd-python` dependency and the `systemd` extra on the `synapse` package. ([#19491](element-hq/synapse#19491)) - Avoid re-computing the event ID when cloning events. ([#19527](element-hq/synapse#19527)) - Allow caching of the `/versions` and `/auth_metadata` public endpoints. ([#19530](element-hq/synapse#19530)) - Add a few labels to the number groupings in the `Processed request` logs. ([#19548](element-hq/synapse#19548)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/5040 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

Fix CI job pointing to non-existent image

8648bab

See #19475 (comment)

MadLittleMods mentioned this pull request Mar 3, 2026

Fix Complement CI not running against the code from our PRs (remote images being chosen over local) #19475

Merged

5 tasks

MadLittleMods added 2 commits March 3, 2026 10:37

Add changelog

903fe80

Merge branch 'develop' into madlittlemods/fix-complement-image-ghcr-ci

8c3bfd0

MadLittleMods commented Mar 3, 2026

View reviewed changes

MadLittleMods marked this pull request as ready for review March 3, 2026 17:12

MadLittleMods requested a review from a team as a code owner March 3, 2026 17:12

Merge branch 'develop' into madlittlemods/fix-complement-image-ghcr-ci

ffea8ce

sandhose approved these changes Mar 16, 2026

View reviewed changes

Comment thread .github/workflows/push_complement_image.yml Outdated

MadLittleMods added 2 commits March 16, 2026 15:46

Merge branch 'develop' into madlittlemods/fix-complement-image-ghcr-ci

995deca

Reference sources of truth

7c60c7f

See #19523 (comment)

MadLittleMods merged commit 6254e00 into develop Mar 17, 2026
71 of 73 checks passed

MadLittleMods deleted the madlittlemods/fix-complement-image-ghcr-ci branch March 17, 2026 02:56

MadLittleMods mentioned this pull request Mar 17, 2026

Fix Build and push complement image CI job not having Poetry for complement.sh #19578

Merged

3 tasks

MadLittleMods commented Mar 17, 2026

View reviewed changes

MadLittleMods added a commit that referenced this pull request Mar 17, 2026

Restore localhost/complement-synapse change from #19523

c37a5bb

See #19523 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `Build and push complement image` CI job pointing to non-existent image#19523

Fix `Build and push complement image` CI job pointing to non-existent image#19523
MadLittleMods merged 6 commits into
developfrom
madlittlemods/fix-complement-image-ghcr-ci

MadLittleMods commented Mar 3, 2026 •

edited

Loading

Uh oh!

MadLittleMods Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

MadLittleMods commented Mar 17, 2026

Uh oh!

MadLittleMods Mar 17, 2026

Uh oh!

MadLittleMods Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	# Tag local builds with a dummy registry namespace so that later builds may reference
	# them exactly instead of accidentally pulling from a remote registry.
	#
	# This is important as some storage drivers/types prefer remote images over local
	# (`containerd`) which causes problems as we're testing against some remote image that
	# doesn't include all of the changes that we're trying to test (be it locally or in a PR
	# in CI). This is spawning from a real-world problem where the GitHub runners were
	# updated to use Docker Engine 29.0.0+ which uses `containerd` by default for new
	# installations.
	LOCAL_IMAGE_NAMESPACE=localhost

	# The image tags for how these images will be stored in the registry
	SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse"
	SYNAPSE_WORKERS_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/synapse-workers"
	COMPLEMENT_SYNAPSE_IMAGE_PATH="$LOCAL_IMAGE_NAMESPACE/complement-synapse"

Conversation

MadLittleMods commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Checklist

Uh oh!

MadLittleMods Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MadLittleMods commented Mar 17, 2026

Uh oh!

MadLittleMods Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

MadLittleMods Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MadLittleMods commented Mar 3, 2026 •

edited

Loading

MadLittleMods Mar 3, 2026 •

edited

Loading