ChooseProjectButton: ellipsize long radio items#1043
Merged
Conversation
* FileView responsible for removing project from GitManager when closed
# Conflicts fixed in: # src/Dialogs/NewBranchDialog.vala
get_radio_group () Co-authored-by: Daniel Foré <daniel@elementary.io>
Co-authored-by: Daniel Foré <daniel@elementary.io>
Co-authored-by: Daniel Foré <daniel@elementary.io>
Collaborator
|
I guess this is required as a consequence of constraining the width of the popover and the width of the button to be the same. Is there any downside to allowing the popover to expand to show the full project name (i.e. removing the sizegroup)? |
* ChooseProjectButton: use a liststore to populate project list * scope down manager * smaller diff * remove unused method
Collaborator
|
I agree with the middle ellipsize for th button though. |
Co-authored-by: Daniel Foré <daniel@elementary.io>
Collaborator
|
This is how it looks if you remove the size group and instead use the same character with for the search entry as for the button label. With a long project name |
* ChooseProjectButton: simplify ProjectRow click handling * actual fix
jeremypw
reviewed
May 21, 2021
Collaborator
jeremypw
left a comment
jeremypw
left a comment
There was a problem hiding this comment.
I have suggested an alternative - I think it would be better to see the full name in the popover.
Member
Author
|
@jeremypw Removed the sizegroup instead, but kept middle ellipsize 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure we also handle ellipsizing radio items
Change ellipsize mode to middle to disambiguate cases like
switchboard-plug-foowhere relevant information is at the beginning and end