Skip to content

ChooseProjectButton: ellipsize long radio items #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremypw merged 37 commits into from
May 26, 2021
Merged

ChooseProjectButton: ellipsize long radio items #1043

Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5352968
Add ChooseProjectButton class
May 15, 2021
7a2b03c
Add ChooseProjectButton to HeaderBar and react to add/remove project
May 16, 2021
298139e
ChooseProjectButton.vala: Update header
May 16, 2021
2ee3d6f
Fix lint
May 16, 2021
197be39
Use HeaderBar active project new-branch action
May 16, 2021
5af4ed9
Use ChooseProjectButton active project for find-global action
May 16, 2021
7aefcaa
Fix closing all except
May 16, 2021
84737c1
ChooseProjectButton: Expand horizontally, add top & bottom margins
May 17, 2021
aae4b4e
ChooseProjectButton: Limit width to 24 chars
May 19, 2021
2f596a0
Merge branch 'master' into choose-project-popover
May 19, 2021
c9a8a16
ChooseProjectButton: Set max chars and ellipsize
May 19, 2021
21ae87e
ChooseProjectButton: use max_content_height for scrolled (#1038)
danirabbit May 19, 2021
0881614
ChooseProjectButton: bind ProjectEntry radio to active (#1040)
danirabbit May 19, 2021
9154111
ChooseProjectButton: valign center (#1037)
danirabbit May 19, 2021
fdcbf79
ChooseProjectButton: subclass menubutton (#1039)
danirabbit May 19, 2021
4a964c9
Merge branch 'master' into choose-project-popover
May 19, 2021
86ba6f6
ChooseProjectButton.vala: Lose unused code
May 19, 2021
c1040c8
Show project path in tooltip
May 19, 2021
cb09a3f
Replace missing brace
May 19, 2021
b1765ce
ProjectEntry: Rename to ProjectRow
May 19, 2021
fb0cbca
Remove duplicated code
May 19, 2021
f3efbf7
Update src/Widgets/ChooseProjectButton.vala
May 19, 2021
99248a1
Update src/Widgets/ChooseProjectButton.vala: Explict get/set
May 19, 2021
014c05d
More concise names
May 19, 2021
4219468
Reduce scope if `img`
May 19, 2021
ac59425
ChooseProjectButton: ellipsize long radio items
danirabbit May 19, 2021
122028a
ChooseProjectButton: use a liststore to populate project list (#1042)
danirabbit May 20, 2021
0ccd722
Merge branch 'master' into choose-project-popover
May 20, 2021
02570fb
Update src/Widgets/HeaderBar.vala: remove unused setter
May 20, 2021
219c985
GitManager: source of truth for active_project_path (#1044)
May 20, 2021
0685c5a
ChooseProjectButton: simplify ProjectRow click handling (#1041)
danirabbit May 20, 2021
c17fbcc
Merge branch 'master' into choose-project-popover
May 20, 2021
6bf8716
Allow non-git projects to fix global search (#1045)
danirabbit May 21, 2021
4619600
Remove size group
danirabbit May 21, 2021
d7cef38
Merge branch 'choose-project-popover' into danrabbit/choose-project-p…
danirabbit May 21, 2021
ec43c83
Merge branch 'master' into danrabbit/choose-project-popover-ellipsize…
danirabbit May 25, 2021
80e60c8
Merge branch 'master' into danrabbit/choose-project-popover-ellipsize…
May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/Widgets/ChooseProjectButton.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class Code.ChooseProjectButton : Gtk.MenuButton {

label_widget = new Gtk.Label (_(NO_PROJECT_SELECTED)) {
width_chars = 24,
ellipsize = Pango.EllipsizeMode.END,
ellipsize = Pango.EllipsizeMode.MIDDLE,
max_width_chars = 24,
xalign = 0.0f
};
Expand Down Expand Up @@ -87,10 +87,6 @@ public class Code.ChooseProjectButton : Gtk.MenuButton {

popover = project_popover;

var hsizegroup = new Gtk.SizeGroup (Gtk.SizeGroupMode.HORIZONTAL);
hsizegroup.add_widget (this);
hsizegroup.add_widget (project_listbox);

project_listbox.bind_model (
Scratch.Services.GitManager.get_instance ().project_liststore,
create_project_row
Expand Down