Skip to content

Check if we're in a VM#326

Closed
cassidyjames wants to merge 37 commits intomasterfrom
check-if-vm
Closed

Check if we're in a VM#326
cassidyjames wants to merge 37 commits intomasterfrom
check-if-vm

Conversation

@cassidyjames
Copy link
Copy Markdown
Contributor

@cassidyjames cassidyjames commented May 1, 2018

Fixes #323

  • Update copyright date while we're here
  • Add a check to see if we're in a VM based on cpuinfo flags
  • Change enough_power to minimum_specs to reduce confusion
  • Move encrypt_view to its logical place in MainWindow.vala
  • Revert a lot of the check view magic as it appears to be broken with multiple conditions (i.e. on battery and in a VM)

Screenshot from my VM:

image

Ready for review.

@cassidyjames cassidyjames added the Status: In Progress Someone is working on it label May 1, 2018
@cassidyjames cassidyjames removed the Status: In Progress Someone is working on it label May 1, 2018
@cassidyjames cassidyjames requested a review from danirabbit May 1, 2018 06:24
@cassidyjames
Copy link
Copy Markdown
Contributor Author

I think there's a better way of checking that through CPU kernel flags file… There's a hypervisor flag in /proc/cpuinfo when we're running on a VM
@donadigo

@cassidyjames
Copy link
Copy Markdown
Contributor Author

Confirmed to work in VirtualBox here, should probably double-check other VM software for sanity.

@cassidyjames
Copy link
Copy Markdown
Contributor Author

Spinning up a VMware machine for testing, though with the distinst changes that might be difficult.

@cassidyjames
Copy link
Copy Markdown
Contributor Author

cassidyjames commented Jun 15, 2018

Confirmed to work in VMware. Now the only problem I see:

  • only loads when the user chooses a clean install, but not a custom partition

@cassidyjames cassidyjames added the Status: In Progress Someone is working on it label Jun 15, 2018
@cassidyjames cassidyjames removed the request for review from danirabbit June 15, 2018 23:34
@cassidyjames
Copy link
Copy Markdown
Contributor Author

Fixed the previous comment, but it feels a little dirty. Help/input welcome! 😁

@jeremypw
Copy link
Copy Markdown
Collaborator

@cassidyjames Converting to draft as labelled "In Progress", has conflicts, and no recent progress.

@jeremypw jeremypw marked this pull request as draft April 30, 2021 10:40
@meisenzahl meisenzahl mentioned this pull request Dec 7, 2021
@cassidyjames
Copy link
Copy Markdown
Contributor Author

Closing in favor of #625

@danirabbit danirabbit deleted the check-if-vm branch November 20, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: In Progress Someone is working on it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warn about VMs

6 participants