Check if we're in a VM#326
Closed
cassidyjames wants to merge 37 commits intomasterfrom
Closed
Conversation
Contributor
Author
|
Contributor
Author
|
Confirmed to work in VirtualBox here, should probably double-check other VM software for sanity. |
Contributor
Author
|
Spinning up a VMware machine for testing, though with the distinst changes that might be difficult. |
Contributor
Author
|
Confirmed to work in VMware. Now the only problem I see:
|
Contributor
Author
|
Fixed the previous comment, but it feels a little dirty. Help/input welcome! 😁 |
Collaborator
|
@cassidyjames Converting to draft as labelled "In Progress", has conflicts, and no recent progress. |
Merged
Contributor
Author
|
Closing in favor of #625 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323
cpuinfoflagsenough_powertominimum_specsto reduce confusionencrypt_viewto its logical place in MainWindow.valaScreenshot from my VM:
Ready for review.