Warn about VMs#625
Merged
danirabbit merged 15 commits intomasterfrom Dec 9, 2021
Merged
Conversation
meisenzahl
commented
Dec 7, 2021
cassidyjames PR
Member
Author
|
@cassidyjames sorry I was not aware of #326. Last commit changed the layout based on your PR:
|
Closed
Contributor
|
@meisenzahl shouldn't this be a part of CheckView where we perform other checks before installing? |
Member
Author
|
@cassidyjames please excuse the confusion with your PR. There is now a warning when it detects that Installer is running in a virtual machine. I took the logic almost 1:1 from your PR. In addition, I have managed to display several warnings one after the other. Peek.2021-12-08.20-20.mp4The checks are not executed for
Let's try to fix this in a follow-up PR. |
danirabbit
approved these changes
Dec 9, 2021
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I can confirm that this works as intended and that checkview code looks really not fun to work, so thank you for working on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #323
Shows a warning as first view if running in a virtualized environment.
Simple solution
Shutdown button
Maybe a bit too much with a suggested shutdown button.