This repository was archived by the owner on Dec 8, 2024. It is now read-only.
Conversation
rwjblue
reviewed
Feb 19, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Overall looks good, needs a small bit of linting cleanup but otherwise ready to go...
Adds an option to import `Ember` rather than relying on the global. This will allow this babel plugin to continue working after the global has been deprecated.
pzuraq
force-pushed
the
feat/add-use-ember-module-flag
branch
from
882b4b3 to
c35ba4d
Compare
This was referenced Mar 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to import
Emberrather than relying on the global. Thiswill allow this babel plugin to continue working after the global has
been deprecated.
Related to: ember-cli/babel-plugin-ember-modules-api-polyfill#175