Add useEmberModule option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+).#175
Merged
rwjblue merged 2 commits intoember-cli:masterfrom Feb 16, 2021
Conversation
rwjblue
requested changes
Feb 2, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Also needs to add ember import when it replaces other imports.
Test case:
// input
import Component from '@ember/component';
export default class extends Component {}// output
import Ember from 'ember';
export default class extends Ember.Component {}
rwjblue
reviewed
Feb 2, 2021
* Ensure import is only added if needed * Use `scope.generateUidIdentifier` to create the new local when needed * Ensure the identifier rewriting code uses the correct identifier
rwjblue
force-pushed
the
add-option-to-preserve-ember-import
branch
from
6408f46 to
61b457e
Compare
Member
|
Fixed a few issues and updated (along with a rebase). |
rwjblue
approved these changes
Feb 15, 2021
rwjblue
changed the title
ember module usage (to avoid global window.Ember deprecation on Ember 3.27+).
rwjblue
changed the title
ember module usage (to avoid global window.Ember deprecation on Ember 3.27+).useEmberModule option to force ember module usage (to avoid global window.Ember deprecation on Ember 3.27+).
This was referenced Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: emberjs/ember.js#19357