Deprecate window global

[NullVoxPopuli]

No description provided.

[rwjblue]

I think this will also need a couple of tests

[pzuraq]

So had a quick convo with @rwjblue about this, and we realized we're going to need to make some additional changes. Currently, ember-cli-babel still transpiles import * from '@ember/*' to use the Ember global, and it does not add import Ember from 'ember'; at the top. In addition, we don't actually define an ember module - that is also transpiled via ember-cli-babel.

So, in this package we need to add the Ember package so you can actually import it. In the babel plugin that ember-cli-babel adds, we need to update it to use import Ember from 'ember'; to the top. It should also only do that IF the Ember version is high enough, so probably 3.26.0-beta.1 assuming we get this PR in before then.

[NullVoxPopuli]

Next Steps?:

• update ember-cli-babel
• add deprecation guide
• add tests for this deprecation in both ember.js and ember-cli-babel
• merge this PR?

[rwjblue]

In order to land we need to:

• Update https://github.com/ember-cli/babel-plugin-ember-modules-api-polyfill
  • Add a new configuration option (useEmberModule maybe?) to opt in to emitting the import Ember from 'ember'; bit or doing the (currently default) "just use window.Ember" thing
• Update ember-cli-babel
  • to use that new version of babel-plugin-ember-modules-api-polyfill
  • to pass true or false to that new option based on the running version of ember-source
• Update this PR to actually emit a ember module (current Ember apps actually have no ember module at runtime, we have to fix that)

[rwjblue]

Hmm, I don't think we should redefine it. If we do, then you won't have a deprecation for every usage of Ember without importing (you'd only get on deprecation). This would make finding and fixing any global accessing quite difficult.

[rwjblue]

This one also needs to be Object.defineProperty(context.exports, 'Em' with a deprecation

[btecu]

Aren't there some important parts that have not been exposed via modules yet? How would that work with this?
For example Ember.onerror, is used for error trackers such as Bugsnag and Sentry.

[pzuraq]

@btecu as noted in the RFC, you will still be able to import Ember from 'ember';. This is just about accessing the object without importing it.

[NullVoxPopuli]

babel plugin: ember-cli/babel-plugin-ember-modules-api-polyfill#175

[pzuraq]

@NullVoxPopuli can you rebase this PR? Now that #19390 has landed, everything should be much easier to deprecate since the global is now setup lazily (you can do it in @ember/-internals/bootstrap). Also we need to add a test that verifies the deprecation runs when we use the global value

[rwjblue]

https://github.com/ember-cli/babel-plugin-ember-modules-api-polyfill/releases/tag/v3.3.0 includes new useEmberModule option. Next up: update ember-cli-babel.

[simonihmig]

This has been superseded by #19457, so can be closed, right?