Add deprecation for the Ember Global#19457
Merged
pzuraq merged 1 commit intoemberjs:masterfrom Mar 18, 2021
Merged
Conversation
Contributor
Author
|
Ah I have some failing tests I need to resolve 😬 |
2a17bc6 to
c9a8c86
Compare
Contributor
|
@patocallaghan I'm actually detangling some things to do with this now, turns out that the Globals resolver/namespaces are being accessed when logging class names 😬 I'm going to see if I can't remove that code in a separate PR that you can rebase on top of |
Contributor
Author
6dd1f14 to
04f28b2
Compare
Contributor
Author
|
Rebased to pick up the changes from #19467 |
pzuraq
approved these changes
Mar 18, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Towards RFC 706
Adds a deprecation for the Ember Global
Can this PR be merged as-is or do we need to wait for a new release of ember-cli-babel with emberjs/ember-cli-babel#382?