Deprecate the Ember Global

[pzuraq]

Rendered

[SergeAstapov]

@pzuraq maybe I'm missing something, could you please describe how we could do tree shaking if we do import Ember from 'ember';? Would build system look which props get used from Ember objet imported that way (that seem like more complex that tree shaking based on imports)?

[pzuraq]

@SergeAstapov it's actually the opposite, if you do not import Ember from 'ember'; anywhere in your application, then we can treeshake.

Today, we can't even if you do not import it explicitly, because any code anywhere could reference the Ember global dynamically.

[SergeAstapov]

@pzuraq thanks for clarification!

[rwjblue]

We discussed this at todays core team meeting, and are moving it into final comment period.

[xg-wang]

How is this going to affect ember-inspector? It accesses Ember app from the global https://github.com/emberjs/ember-inspector/blob/v4.3.4/ember_debug/main.js#L14

Ref: https://discord.com/channels/480462759797063690/486243207072710656/803662597835456542

[pzuraq]

Ember Inspector uses a lot of intimate/private APIs, so we can expose something for it to read to get access to the things it needs. It doesn't need to be public, so we can figure out the details when the time comes.