load template-compiler from ember-source#68
Merged
stefanpenner merged 4 commits intomasterfrom May 22, 2016
Merged
Conversation
8 tasks
| htmlbarsOptions: function() { | ||
| var projectConfig = this.projectConfig() || {}; | ||
| var EmberENV = projectConfig.EmberENV || {}; | ||
| var templateCompilerPath = this.templateCompilerPath() + '.js'; |
Member
There was a problem hiding this comment.
this is required to properly clear the cache below (because the path is stored with its extension in the cache)
Contributor
Author
There was a problem hiding this comment.
hmm this.templateCompilerPath() now returns (sometimes with '.js')
I can add a ensureEndsInJs() or something
Contributor
Author
There was a problem hiding this comment.
@rwjblue i think https://github.com/ember-cli/ember-cli-htmlbars/pull/68/files#diff-fc695117845e9b76dfb1841d2221ac7cR72 handles this already?
Contributor
Author
There was a problem hiding this comment.
ah, we already had this conversation :P #68 (comment)
Member
|
This looks good except for that one nit-pick/correction RE: extension. |
Contributor
Author
Member
|
Ya, that looks good. |
* fallback to old * don’t append ‘.js’ as require already does this
stefanpenner
force-pushed
the
ember-source
branch
from
9f7bf84 to
dbe5bf1
Compare
Contributor
Author
|
got r+ from @chadhietala |
Contributor
Author
|
@homu r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.