provide ember-core from NPM by stefanpenner · Pull Request #13022 · emberjs/ember.js

stefanpenner · 2016-02-28T00:03:07Z

obviate the need to bower install ember.js
provide an api for addons to retrieve paths to
ember.debug.js, ember.prod.js and
ember-template-compiler.js
actually decide on name
shims
throw if ember-cli version does not support this
ember-data fix -> ember-cli-shim check errors if no shim is provided warp-drive-data/warp-drive#4192
~~on-demand build for master, and maybe beta?~~ can happen after
release
rename to ember-source - ember ember-cli ember-cli-legacy-blueprints
~~backport to release~~ (decided to let it ride the beta cycle so folks can test)

chadhietala · 2016-02-28T00:25:30Z

How about "ember-core"? I liked @mixonic's "bark" analogy which alludes to Ember as the "core competency" of the Ember ecosystem.

As a somewhat tangential comment, I would love to actually see Ember CLI move under the ember repo but released as a separate package. I think this may help with lock stepping projects, overall maintainability, and leverage/integration of tech. A thing working at mega corp has taught me is that for big projects lean towards giant code bases with multiple deployables.

stefanpenner · 2016-02-28T00:26:53Z

@chadhietala the reason for an alternative name is to create a meta package named ember, which is what you describe (i believe).

fivetanley · 2016-02-28T02:36:46Z

I would love to actually see Ember CLI move under the ember repo but released as a separate package

For us on the Ember Data subteam, this seems to create an undue burden on core. We have difficulty getting any settings changed because of the various permission levels Github provides. I think ember-cli remaining its own org empowers its subteam to handle their own tools and collaborators, and core can always commit as they are also in that org.

stefanpenner · 2016-02-28T03:50:26Z

We should stay in topic. We just need a name for ember-source. So we can reserve ember for a future meta package.

mixonic · 2016-02-28T20:50:10Z

@stefanpenner In the 2/19 core meeting we seemed to settle on ember-core as the name. Some discussion under "ember npm package" in the notes.

homu · 2016-03-15T01:47:33Z

☔ The latest upstream changes (presumably #13029) made this pull request unmergeable. Please resolve the merge conflicts.

Turbo87 · 2016-03-15T09:13:38Z

@stefanpenner what's the state of this PR? can I help to move this forward?

rwjblue · 2016-03-15T11:21:05Z

Needs a rebase and updating to 'ember-core' as the name. Other than that, I think it's mostly good to land (we can continue to tweak while on master before pushing to NPM).

stefanpenner · 2016-03-15T22:17:20Z

rebasing now

stefanpenner · 2016-03-15T22:20:24Z

@rwjblue updated, i think all the remains is:

on-demand build for master, and maybe beta?

Im unsure if this is a blocker, although I can begin working on it over the next few days. (I have small bursts of time)

krisselden · 2016-03-16T00:39:02Z

package.json

    "ember-cli-test-info": "^1.0.0",
-    "ember-cli-valid-component-name": "^1.0.0"
+    "ember-cli-valid-component-name": "^1.0.0",
+    "simple-dom": "^0.2.7",


did you mean to downgrade this or was this a rebase issue?

rebase issue, fixing

stefanpenner · 2016-03-16T01:08:33Z

Rebase thing likely

Turbo87 · 2016-04-12T18:37:10Z

@stefanpenner still working on this PR? can I help somehow to bring it over the finish line?

stefanpenner · 2016-05-12T16:26:37Z

@stefanpenner still working on this PR? can I help somehow to bring it over the finish line?

I'm going to work on it this week, sorry for letting it linger.

stefanpenner · 2016-05-22T21:55:24Z

@rwjblue this should land on canary confirm?

@mixonic any shims that need fixed/updated/sync'd here is the place let me know.

rwjblue · 2016-05-22T22:29:48Z

Yes, let's target canary. It will branch into beta (for 2.7.0) in a couple days.

stefanpenner · 2016-05-22T23:01:26Z

@rwjblue this currently wont actually support canary, as it does not yet work with non-prebuilt versions. Its likely ok as it will hit beta soon. I have some other work, then i'll circle back and make this work on canary, but that will most likely result in a refactoring to emberjs-build etc.

mixonic · 2016-05-24T00:24:51Z

vendor/ember/shims.js

+        'default': Ember.inject.controller
+      },
+      'ember-controller/proxy': {
+        'default': Ember.ArrayProxy


This one felt surprising- ArrayProxy in the ember-controller namespace.

Re: ember-cli/ember-cli-shims#60

I guess SortableMixin is in the same boat. Often used for controllers, but the coupling to the namespace seems odd (if we drop controllers, we will be forced to move/rename ArrayProxy and SortableMixin).

In fact ObjectProxy is just missing re: ember-cli/ember-cli-shims#36. Perhaps we should add a ember-proxy group 😬

mixonic · 2016-05-24T00:31:38Z

Presented as a checklist so we can check each as "resolved" whether by action or inaction:

Three above:

ArrayProxy is in ember-controller/proxy, seems odd re: ember-controller/proxy exports ArrayProxy ember-cli/ember-cli-shims#60
SortableMixin is in ember-controllers/sortable, which is a bit odd and the only use of plural controllers
ObjectProxy is public but no exported re: Ember.ObjectProxy should be exported ember-cli/ember-cli-shims#36

Two others:

PromiseProxyMixin is public and not exported, re: Ember.PromiseProxyMixin should be exported ember-cli/ember-cli-shims#37
Logger is public and not exported, re: Ember.Logger should be exported ember-cli/ember-cli-shims#56

stefanpenner · 2016-09-25T19:16:32Z

@stefanpenner since we already ship ember-cli-shims by default (in Ember CLI) why not keep them in ember.js but declare them as experimental and not yet public for now? I guess shipping ember.js without the shims might actually break some things unless we want to keep shipping the shims separately via bower.

yes, most likely just do this. Coupling this effort to sorting out the public module API has stifled this effort.

stefanpenner · 2016-09-25T19:16:55Z

rebased, running tests now.

stefanpenner · 2016-09-25T20:14:50Z

Looks like only the blueprint tests are failing (on CI). Taking a look

Turbo87 · 2016-09-25T20:23:54Z

also: "DEPRECATION: Overriding init without calling this._super is deprecated. Please call this._super.init && this._super.init.apply(this, arguments); addon: ember-core" 😉

#13022 (comment)

stefanpenner · 2016-09-25T21:44:35Z

Alright, green on this end. At one point this did work end-to-end, it may still?

Turbo87 · 2016-09-25T21:59:37Z

I'd say and find out!

stefanpenner · 2016-09-25T22:09:32Z

Turbo87 someone should try with and without this, and confirm it works. I may have time later this week. If we can make it seamless we have an OK to 🚢

locks · 2016-09-25T23:52:48Z

@stefanpenner Working with a brand new app and super-rentals.

[edit] And a production app of mine.

Update package.json

stefanpenner · 2016-10-07T20:06:34Z

emberjs#13022 (comment)

stefanpenner mentioned this pull request Feb 28, 2016

load template-compiler from ember-source ember-cli/ember-cli-htmlbars#68

Merged

2 tasks

chadhietala mentioned this pull request Feb 28, 2016

Ember CLI Runtime Code Migration to NPM via Addons ember-cli/ember-cli#4546

Closed

12 tasks

Turbo87 mentioned this pull request Mar 4, 2016

Add basic ember-cli addon structure #13000

Merged

Turbo87 mentioned this pull request Mar 15, 2016

load ember from ember-core if available ember-cli/ember-cli#5531

Merged

2 tasks

stefanpenner force-pushed the ember-source branch from 9000502 to 737a034 Compare March 15, 2016 22:18

krisselden reviewed Mar 16, 2016
View reviewed changes

stefanpenner mentioned this pull request Mar 17, 2016

Move into future "ember" addon ember-cli/ember-cli-shims#15

Closed

1 task

stefanpenner self-assigned this May 12, 2016

stefanpenner changed the title ~~provide ember-source from NPM~~ provide ember-core from NPM May 20, 2016

stefanpenner force-pushed the ember-source branch 3 times, most recently from 363ba57 to 218a0c4 Compare May 22, 2016 21:05

mixonic reviewed May 24, 2016
View reviewed changes

stefanpenner and others added 4 commits September 25, 2016 12:11

throw if ember is also provided as a bowerDep

47467a5

change name from ember-source -> ember-core

c30bad5

provide jQuery for now

bf34870

Add getOwner/setOwner shims

75876e5

stefanpenner force-pushed the ember-source branch from f8440f3 to 75876e5 Compare September 25, 2016 19:15

stefanpenner added 2 commits September 25, 2016 13:27

fix core-object deprecation, as per:

df4d6e9

#13022 (comment)

move throw to warn for now.

29680aa

locks mentioned this pull request Sep 28, 2016

Attempting to install latest Ember as a node package is failling #12573

Closed

locks and others added 4 commits September 30, 2016 20:42

Update package.json

3854b35

Update package.json

aec0fec

Update index.js

4b1cbe9

Merge pull request #14396 from emberjs/locks-patch-2

eead311

Update package.json

rwjblue merged commit 454442b into master Oct 7, 2016

kimroen mentioned this pull request Oct 7, 2016

Change name of ember npm package in after kimroen/ember-cli-coffeescript#121

Closed

This was referenced Oct 10, 2016

RFC wanted: Migration plan off of bower. ember-cli/rfcs#41

Closed

make bower optional ember-cli/ember-try#101

Closed

mixonic pushed a commit to mixonic/ember.js that referenced this pull request Oct 22, 2016

fix core-object deprecation, as per:

0531438

emberjs#13022 (comment)

rwjblue deleted the ember-source branch May 16, 2018 17:58

Uh oh!

Conversation

stefanpenner commented Feb 28, 2016 • edited by rwjblue Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chadhietala commented Feb 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanpenner commented Feb 28, 2016

Uh oh!

fivetanley commented Feb 28, 2016

Uh oh!

stefanpenner commented Feb 28, 2016

Uh oh!

mixonic commented Feb 28, 2016

Uh oh!

homu commented Mar 15, 2016

Uh oh!

Turbo87 commented Mar 15, 2016

Uh oh!

rwjblue commented Mar 15, 2016

Uh oh!

stefanpenner commented Mar 15, 2016

Uh oh!

stefanpenner commented Mar 15, 2016

Uh oh!

krisselden Mar 16, 2016

Choose a reason for hiding this comment

Uh oh!

stefanpenner May 22, 2016

Choose a reason for hiding this comment

Uh oh!

stefanpenner commented Mar 16, 2016

Uh oh!

Turbo87 commented Apr 12, 2016

Uh oh!

stefanpenner commented May 12, 2016

Uh oh!

stefanpenner commented May 22, 2016

Uh oh!

rwjblue commented May 22, 2016

Uh oh!

stefanpenner commented May 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mixonic May 24, 2016

Choose a reason for hiding this comment

Uh oh!

mixonic May 24, 2016

Choose a reason for hiding this comment

Uh oh!

mixonic commented May 24, 2016

Uh oh!

stefanpenner commented Sep 25, 2016

Uh oh!

stefanpenner commented Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanpenner commented Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Turbo87 commented Sep 25, 2016

Uh oh!

stefanpenner commented Sep 25, 2016

Uh oh!

Turbo87 commented Sep 25, 2016

Uh oh!

stefanpenner commented Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

locks commented Sep 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stefanpenner commented Oct 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

stefanpenner commented Feb 28, 2016 •

edited by rwjblue

Loading

chadhietala commented Feb 28, 2016 •

edited

Loading

stefanpenner commented May 22, 2016 •

edited

Loading

stefanpenner commented Sep 25, 2016 •

edited

Loading

stefanpenner commented Sep 25, 2016 •

edited

Loading

stefanpenner commented Sep 25, 2016 •

edited

Loading

locks commented Sep 25, 2016 •

edited

Loading