Conversation
|
We should check how far back findAddonByName goes, this project still supports early 1.13.x versions of Ember CLI. So we would either need to bump majors or detect and fallback (either is fine with me). @stefanpenner - What do you think? |
|
Ugh, that comment was for the ember-cli-htmlbars PR not this one, sorry about the noise :( |
|
This looks good to me, not sure why it's failing though (haven't dug into the Travis errors). |
lib/broccoli/ember-app.js
Outdated
| var defaultDevelopmentEmber = this.bowerDirectory + '/ember/ember.debug.js'; | ||
| if (!existsSync(path.join(this.project.root, defaultDevelopmentEmber))) { | ||
| defaultDevelopmentEmber = this.bowerDirectory + '/ember/ember.js'; | ||
| var ember = this.project.findAddonByName('ember-source'); |
There was a problem hiding this comment.
the discussion in emberjs/ember.js#13022 seemed to have converged on using ember-core instead of ember-source
There was a problem hiding this comment.
update to ember-core
stefanpenner
force-pushed
the
ember-source
branch
from
adaee2b to
1a6cc0f
Compare
|
@stefanpenner LGTM r+ I think we can merge this already even though |
stefanpenner
changed the title
|
📌 Commit 1a6cc0f has been approved by |
load ember from ember-core if available cc @rwjblue - [x] choose ember module name - [ ] ship ember-core module
|
☀️ Test successful - status |
4 participants
cc @rwjblue