-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
provide ember-core from NPM #13022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide ember-core from NPM #13022
Changes from all commits
3d104c9
8757bfc
47467a5
c30bad5
bf34870
75876e5
df4d6e9
29680aa
3854b35
aec0fec
4b1cbe9
eead311
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,58 @@ | ||
| /* jshint node: true */ | ||
| 'use strict'; | ||
| var stew = require('broccoli-stew'); | ||
|
|
||
| var paths = {}; | ||
| var absolutePaths = {}; | ||
|
|
||
| function add(paths, name, path) { | ||
| Object.defineProperty(paths, name, { | ||
| configurable: false, | ||
| get: function() { return path; } | ||
| }); | ||
| } | ||
|
|
||
| add(paths, 'prod', 'vendor/ember/ember.prod.js'); | ||
| add(paths, 'debug', 'vendor/ember/ember.debug.js'); | ||
| add(paths, 'shims', 'vendor/ember/shims.js'); | ||
| add(paths, 'jquery', 'vendor/ember/jquery/jquery.js'); | ||
|
|
||
| add(absolutePaths, 'templateCompiler', __dirname + '/dist/ember-template-compiler.js'); | ||
|
|
||
| module.exports = { | ||
| name: 'ember' | ||
| init: function() { | ||
| this._super.init && this._super.init.apply(this, arguments); | ||
| if ('ember' in this.project.bowerDependencies()) { | ||
| // TODO: move this to a throw soon. | ||
| this.ui.writeWarnLine('Ember.js is now provided by node_module `ember-source`, please remove it from bower'); | ||
| } | ||
| }, | ||
|
|
||
| name: 'ember-source', | ||
| paths: paths, | ||
| absolutePaths: absolutePaths, | ||
| treeForVendor: function() { | ||
| var ember = stew.find(__dirname + '/dist', { | ||
| destDir: 'ember', | ||
| files: [ | ||
| 'ember-runtime.js', | ||
| 'ember-template-compiler.js', | ||
| 'ember-testing.js', | ||
| 'ember.debug.js', | ||
| 'ember.min.js', | ||
| 'ember.prod.js', | ||
| 'jquery/jquery.js' | ||
| ] | ||
| }); | ||
|
|
||
| var shims = stew.find(__dirname + '/vendor/ember', { | ||
| destDir: 'ember', | ||
| files: [ 'shims.js' ] | ||
| }); | ||
|
|
||
| return stew.find([ | ||
| ember, | ||
| shims | ||
| ]); | ||
| } | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,253 @@ | ||
| (function() { | ||
| /* globals define, Ember, jQuery */ | ||
|
|
||
| function processEmberShims() { | ||
| var shims = { | ||
| 'ember': { | ||
| 'default': Ember | ||
| }, | ||
| 'ember-application': { | ||
| 'default': Ember.Application | ||
| }, | ||
| 'ember-array': { | ||
| 'default': Ember.Array | ||
| }, | ||
| 'ember-array/mutable': { | ||
| 'default': Ember.MutableArray | ||
| }, | ||
| 'ember-array/utils': { | ||
| 'A': Ember.A, | ||
| 'isEmberArray': Ember.isArray, | ||
| 'wrap': Ember.makeArray | ||
| }, | ||
| 'ember-component': { | ||
| 'default': Ember.Component | ||
| }, | ||
| 'ember-components/checkbox': { | ||
| 'default': Ember.Checkbox | ||
| }, | ||
| 'ember-components/text-area': { | ||
| 'default': Ember.TextArea | ||
| }, | ||
| 'ember-components/text-field': { | ||
| 'default': Ember.TextField | ||
| }, | ||
| 'ember-controller': { | ||
| 'default': Ember.Controller | ||
| }, | ||
| 'ember-controller/inject': { | ||
| 'default': Ember.inject.controller | ||
| }, | ||
| 'ember-controller/proxy': { | ||
| 'default': Ember.ArrayProxy | ||
| }, | ||
| 'ember-controllers/sortable': { | ||
| 'default': Ember.SortableMixin | ||
| }, | ||
| 'ember-debug': { | ||
| 'log': Ember.debug, | ||
| 'inspect': Ember.inspect, | ||
| 'run': Ember.runInDebug, | ||
| 'warn': Ember.warn | ||
| }, | ||
| 'ember-debug/container-debug-adapter': { | ||
| 'default': Ember.ContainerDebugAdapter | ||
| }, | ||
| 'ember-debug/data-adapter': { | ||
| 'default': Ember.DataAdapter | ||
| }, | ||
| 'ember-deprecations': { | ||
| 'deprecate': Ember.deprecate, | ||
| 'deprecateFunc': Ember.deprecateFunc | ||
| }, | ||
| 'ember-enumerable': { | ||
| 'default': Ember.Enumerable | ||
| }, | ||
| 'ember-evented': { | ||
| 'default': Ember.Evented | ||
| }, | ||
| 'ember-evented/on': { | ||
| 'default': Ember.on | ||
| }, | ||
| 'ember-globals-resolver': { | ||
| 'default': Ember.DefaultResolver | ||
| }, | ||
| 'ember-helper': { | ||
| 'default': Ember.Helper, | ||
| 'helper': Ember.Helper && Ember.Helper.helper | ||
| }, | ||
| 'ember-instrumentation': { | ||
| 'instrument': Ember.Instrumentation.instrument, | ||
| 'reset': Ember.Instrumentation.reset, | ||
| 'subscribe': Ember.Instrumentation.subscribe, | ||
| 'unsubscribe': Ember.Instrumentation.unsubscribe | ||
| }, | ||
| 'ember-locations/hash': { | ||
| 'default': Ember.HashLocation | ||
| }, | ||
| 'ember-locations/history': { | ||
| 'default': Ember.HistoryLocation | ||
| }, | ||
| 'ember-locations/none': { | ||
| 'default': Ember.NoneLocation | ||
| }, | ||
| 'ember-map': { | ||
| 'default': Ember.Map, | ||
| 'withDefault': Ember.MapWithDefault | ||
| }, | ||
| 'ember-metal/destroy': { | ||
| 'default': Ember.destroy | ||
| }, | ||
| 'ember-metal/events': { | ||
| 'addListener': Ember.addListener, | ||
| 'removeListener': Ember.removeListener, | ||
| 'send': Ember.sendEvent | ||
| }, | ||
| 'ember-metal/get': { | ||
| 'default': Ember.get | ||
| }, | ||
| 'ember-metal/mixin': { | ||
| 'default': Ember.Mixin | ||
| }, | ||
| 'ember-metal/observer': { | ||
| 'default': Ember.observer, | ||
| 'addObserver': Ember.addObserver, | ||
| 'removeObserver': Ember.removeObserver | ||
| }, | ||
| 'ember-metal/on-load': { | ||
| 'default': Ember.onLoad, | ||
| 'run': Ember.runLoadHooks | ||
| }, | ||
| 'ember-metal/set': { | ||
| 'default': Ember.set, | ||
| 'setProperties': Ember.setProperties, | ||
| 'trySet': Ember.trySet | ||
| }, | ||
| 'ember-metal/utils': { | ||
| 'aliasMethod': Ember.aliasMethod, | ||
| 'assert': Ember.assert, | ||
| 'cacheFor': Ember.cacheFor, | ||
| 'copy': Ember.copy | ||
| }, | ||
| 'ember-object': { | ||
| 'default': Ember.Object | ||
| }, | ||
| 'ember-owner/get': { | ||
| 'default': Ember.getOwner | ||
| }, | ||
| 'ember-owner/set': { | ||
| 'default': Ember.setOwner | ||
| }, | ||
| 'ember-platform': { | ||
| 'assign': Ember.merge, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is also suspect. |
||
| 'create': Ember.create, | ||
| 'defineProperty': Ember.platform.defineProperty, | ||
| 'hasAccessors': Ember.platform.hasPropertyAccessors, | ||
| 'keys': Ember.keys | ||
| }, | ||
| 'ember-route': { | ||
| 'default': Ember.Route | ||
| }, | ||
| 'ember-router': { | ||
| 'default': Ember.Router | ||
| }, | ||
| 'ember-runloop': { | ||
| 'default': Ember.run, | ||
| 'begin': Ember.run.begin, | ||
| 'bind': Ember.run.bind, | ||
| 'cancel': Ember.run.cancel, | ||
| 'debounce': Ember.run.debounce, | ||
| 'end': Ember.run.end, | ||
| 'join': Ember.run.join, | ||
| 'later': Ember.run.later, | ||
| 'next': Ember.run.next, | ||
| 'once': Ember.run.once, | ||
| 'schedule': Ember.run.schedule, | ||
| 'scheduleOnce': Ember.run.scheduleOnce, | ||
| 'throttle': Ember.run.throttle | ||
| }, | ||
| 'ember-service': { | ||
| 'default': Ember.Service | ||
| }, | ||
| 'ember-service/inject': { | ||
| 'default': Ember.inject.service | ||
| }, | ||
| 'ember-set/ordered': { | ||
| 'default': Ember.OrderedSet | ||
| }, | ||
| 'ember-string': { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This list is missing
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think so, it's provided by https://github.com/stefanpenner/ember-inflector
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah! neat will give it a try. |
||
| 'camelize': Ember.String.camelize, | ||
| 'capitalize': Ember.String.capitalize, | ||
| 'classify': Ember.String.classify, | ||
| 'dasherize': Ember.String.dasherize, | ||
| 'decamelize': Ember.String.decamelize, | ||
| 'fmt': Ember.String.fmt, | ||
| 'htmlSafe': Ember.String.htmlSafe, | ||
| 'loc': Ember.String.loc, | ||
| 'underscore': Ember.String.underscore, | ||
| 'w': Ember.String.w | ||
| }, | ||
| 'ember-utils': { | ||
| 'isBlank': Ember.isBlank, | ||
| 'isEmpty': Ember.isEmpty, | ||
| 'isNone': Ember.isNone, | ||
| 'isPresent': Ember.isPresent, | ||
| 'tryInvoke': Ember.tryInvoke, | ||
| 'typeOf': Ember.typeOf | ||
| } | ||
| }; | ||
|
|
||
| // populate `ember/computed` named exports | ||
| shims['ember-computed'] = { | ||
| 'default': Ember.computed | ||
| }; | ||
| var computedMacros = [ | ||
| "empty","notEmpty", "none", "not", "bool", "match", "equal", "gt", "gte", | ||
| "lt", "lte", "alias", "oneWay", "reads", "readOnly", "deprecatingAlias", | ||
| "and", "or", "collect", "sum", "min", "max", "map", "sort", "setDiff", | ||
| "mapBy", "filter", "filterBy", "uniq", "union", "intersect" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need to add |
||
| ]; | ||
|
|
||
| for (var i = 0, l = computedMacros.length; i < l; i++) { | ||
| var key = computedMacros[i]; | ||
| shims['ember-computed'][key] = Ember.computed[key]; | ||
| } | ||
|
|
||
| for (var moduleName in shims) { | ||
| generateModule(moduleName, shims[moduleName]); | ||
| } | ||
| } | ||
|
|
||
| function processTestShims() { | ||
| if (Ember.Test) { | ||
| var testShims = { | ||
| 'ember-test': { | ||
| 'default': Ember.Test | ||
| }, | ||
| 'ember-test/adapter': { | ||
| 'default': Ember.Test.Adapter | ||
| }, | ||
| 'ember-test/qunit-adapter': { | ||
| 'default': Ember.Test.QUnitAdapter | ||
| } | ||
| }; | ||
|
|
||
| for (var moduleName in testShims) { | ||
| generateModule(moduleName, testShims[moduleName]); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function generateModule(name, values) { | ||
| define(name, [], function() { | ||
| 'use strict'; | ||
|
|
||
| return values; | ||
| }); | ||
| } | ||
|
|
||
| processEmberShims(); | ||
| processTestShims(); | ||
| generateModule('jquery', { 'default': self.jQuery }); | ||
| generateModule('rsvp', { 'default': Ember.RSVP }); | ||
| })(); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one felt surprising-
ArrayProxyin theember-controllernamespace.Re: ember-cli/ember-cli-shims#60
I guess
SortableMixinis in the same boat. Often used for controllers, but the coupling to the namespace seems odd (if we drop controllers, we will be forced to move/renameArrayProxyandSortableMixin).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact
ObjectProxyis just missing re: ember-cli/ember-cli-shims#36. Perhaps we should add aember-proxygroup 😬