[Test Load Balancing] Validate load-balance option and enable to load test balanced#136
Merged
stefanpenner merged 28 commits intoember-cli:masterfrom Mar 15, 2019
Merged
Conversation
step2yeung
reviewed
Oct 3, 2018
choheekim
changed the title
load-balance option and enable to load test balancedload-balance option and enable to load test balanced (WIP)
choheekim
force-pushed
the
enable_test_load_balance
branch
from
d0ccccd to
a1c1de4
Compare
scalvert
suggested changes
Oct 5, 2018
choheekim
force-pushed
the
enable_test_load_balance
branch
9 times, most recently
from
480c8b9 to
1d14f5d
Compare
step2yeung
reviewed
Oct 17, 2018
choheekim
force-pushed
the
enable_test_load_balance
branch
4 times, most recently
from
dcb0fa6 to
90e685b
Compare
step2yeung
reviewed
Oct 25, 2018
step2yeung
reviewed
Oct 25, 2018
choheekim
force-pushed
the
enable_test_load_balance
branch
from
becaabe to
c30c1e9
Compare
stefanpenner
requested changes
Oct 29, 2018
step2yeung
reviewed
Oct 30, 2018
choheekim
force-pushed
the
enable_test_load_balance
branch
from
b945358 to
0df5d2f
Compare
Contributor
|
I will attempt to make time tomorrow to do a thorough review. |
choheekim
force-pushed
the
enable_test_load_balance
branch
from
327dcd0 to
d759215
Compare
scalvert
reviewed
Nov 8, 2018
scalvert
reviewed
Nov 8, 2018
step2yeung
reviewed
Mar 6, 2019
step2yeung
reviewed
Mar 6, 2019
choheekim
force-pushed
the
enable_test_load_balance
branch
from
e7f58c0 to
785e9e3
Compare
…s to check whether having to set process callbacks.
choheekim
force-pushed
the
enable_test_load_balance
branch
from
785e9e3 to
df56609
Compare
2. Fix to reset state once tests are complete 3. Add tests against completedBrowsersHandler
… and some renaming
stefanpenner
requested changes
Mar 11, 2019
…version of ember-cli being used
choheekim
force-pushed
the
enable_test_load_balance
branch
from
bbd3699 to
5e80d9a
Compare
step2yeung
reviewed
Mar 12, 2019
choheekim
force-pushed
the
enable_test_load_balance
branch
from
5e80d9a to
3111b89
Compare
step2yeung
reviewed
Mar 12, 2019
choheekim
changed the title
load-balance option and enable to load test balanced (WIP) load-balance option and enable to load test balanced
2. Add 'write-execution-file' option to allow writing test-execution json file after test-execution
choheekim
force-pushed
the
enable_test_load_balance
branch
from
3111b89 to
c691151
Compare
step2yeung
reviewed
Mar 13, 2019
Collaborator
step2yeung
left a comment
step2yeung
left a comment
There was a problem hiding this comment.
@choheekim lemme know if you feel these changes needs to be done for this PR or can land as part of the next PR
choheekim
force-pushed
the
enable_test_load_balance
branch
from
ae79b07 to
3bb25b7
Compare
stefanpenner
requested changes
Mar 14, 2019
choheekim
force-pushed
the
enable_test_load_balance
branch
from
3bb25b7 to
dbf247c
Compare
choheekim
force-pushed
the
enable_test_load_balance
branch
from
dbf247c to
fbbe3a5
Compare
stefanpenner
approved these changes
Mar 15, 2019
Contributor
|
this LGTM, time to merge. Release will occur once we land: #136 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains two changes:
The weight-test-modules allows ordering a list of AMD modules by slowest to fastest test type where we assume that acceptance tests are the slowest test type, with integration, unit tests and lint test being fast and faster and fastest. Sorting the list of AMD modules will be functioned by default when load-balance option is specified to provide better utilization of browser parallelization.
With load-balance options enabled that the testLoader requires and unsees an AMD module as requested instead of testLoader loads a list of AMD modules all once. As the order of AMD modules ran per browser is not consistent with the load-balance option modules ran per browser are tracked and when all tests are complete it creates a json file which maps from a browser id to a list of AMD modules ran on the browser.