Conversation
|
Is it fair to then describe |
| availableOptions: [ | ||
| { | ||
| name: 'split', | ||
| name: 'partition-count', |
There was a problem hiding this comment.
Although this is more accurate, is the cost of split sufficiently high to require a rename? I worry the churn is more costly then the benefit. Thoughts?
There was a problem hiding this comment.
I personally have to do mental gymnastics to disambiguate the options in their current state. I always convert split to partition count in my mind. I'm in favor of naming it what it is.
I think we could keep both for backwards compatibility, but I'd just opt for a full conversion over with a major bump.
Am open to other thoughts.
| name: 'load-balance', | ||
| type: Boolean, | ||
| default: false, | ||
| name: 'browser-count', |
There was a problem hiding this comment.
browser-count does not, for me anyways, imply load balancing. I wonder if we can do anything about that?
1. `partition-count` replacing `split`
2. `browser-count` replace `load-balance` and `parallel` with load-balancing being defaulted
Newly Proposed Commands
This pr contains changes in command lines in ember-exam.
With the current existing/proposed commands,
--splitsplits the full list of test modules into a number of partitions set by the input value, but--splitfeels lacking in meaning when looking at the command by itself.parallelis a boolean to run tests on multiple browsers and the number of browsers to invoke depending on the combination of commands:splitorpartition. Whenparallelis used withload-balanceparalleltakes a numeric value andparallelis to decide a number of browsers.This confusion raises problems of that the 'parallel' command is convoluted the naming of some of the commands are not straight forward.
Newly proposed commands will replace
splitwithpartition-countand a combination ofload-balanceandparallelwithbrowser-count.partitionremains the same as before to specify the partition to execute.The usage of
browser-countdefaults running tests with load-balancing mode, while keeping the existing commands to run tests as it does today. The new commands tries to remove the convoluted usage, provide more meaningful names and simple usages.Example
*** The pr should come after #136 lands