failing test for looking up in namespace contains a @ sign in module prefix#511
failing test for looking up in namespace contains a @ sign in module prefix#511nightire wants to merge 1 commit intoember-cli:masterfrom nightire:failing-test-case
Conversation
… in module prefix
|
I believe this was fixed by #531, @buschtoens can you confirm? |
| return { default: expected } | ||
| }) | ||
|
|
||
| const component = resolver.resolve('component:@scope/other@component:foo-bar'); |
There was a problem hiding this comment.
| const component = resolver.resolve('component:@scope/other@component:foo-bar'); | |
| const component = resolver.resolve('component:@scope/other@foo-bar'); |
| const component = resolver.resolve('component:@scope/other@component:foo-bar'); | |
| const component = resolver.resolve('@scope/other@component:foo-bar'); |
|
I ran the test locally and it failed, because it includes the type ( I can't speak for the template syntax though, but the resolver side of things works now. 👍 |
|
Awesome, thank you for double checking @buschtoens! |
|
BTW, even though the resolver side of things works, a scoped named component invocation still not possible, I got this error when testing with ember-resolver@8: However it out of the scope of ember-resolver, just leave a note here. |
|
I'm curious, what was your invocation syntax that triggered that error? |
|
@rwjblue something like this: am I doing this right? |

This previously failing test case is for addressing an issue that discussed in discord:
https://discordapp.com/channels/480462759797063690/491905849405472769/682777856446824466
which in short, it is impossible for now to invoke a component from a namespace contains a
@sign in itsmodulePrefix.For example, I have an ember add-on that will be published as
@org/ui-kit. For naming consistency purposes, I set itsmodulePrefixto"@org/ui-kit"as well.However, I can not invoke components in this add-on from any consuming application in this form:
<@org/UiKit@Forms::Input />Although this PR revealed this issue, I still in doubt personally that this form of invocation is a good idea. People can change the
modulePrefixeasily to:<OrgUiKit@Forms::Input />or re-export it as normal ember add-ons did.