Skip to content

failing test for looking up in namespace contains a @ sign in module prefix #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nightire wants to merge 1 commit into from
Closed

failing test for looking up in namespace contains a @ sign in module prefix #511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/unit/resolvers/classic/basic-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,20 @@ test("can lookup something in another namespace with different syntax", function
assert.equal(adapter, expected, 'default export was returned');
});

test("can lookup something in another namespace contains a @ sign in module prefix", function(assert) {
let expected = {};

define('@scope/other/components/foo-bar', [], function() {
assert.ok(true, "component was invoked properly");
return { default: expected }
})

const component = resolver.resolve('component:@scope/other@component:foo-bar');
Copy link
Contributor

@buschtoens buschtoens Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const component = resolver.resolve('component:@scope/other@component:foo-bar');
const component = resolver.resolve('component:@scope/other@foo-bar');
Suggested change
const component = resolver.resolve('component:@scope/other@component:foo-bar');
const component = resolver.resolve('@scope/other@component:foo-bar');


assert.ok(component, 'component was returned');
assert.equal(component, expected, 'default export was returned');
});

test("can lookup a view in another namespace", function(assert) {
assert.expect(3);

Expand Down