Skip to content

Add @ember/string as a peerDep#862

Merged
kategengler merged 1 commit intoember-cli:masterfrom
kategengler:kg-ember-string
Jan 11, 2023
Merged

Add @ember/string as a peerDep#862
kategengler merged 1 commit intoember-cli:masterfrom
kategengler:kg-ember-string

Conversation

@kategengler
Copy link
Member

@ember/string without the external package is deprecated in ember-source v4.10

@kategengler
Copy link
Member Author

From @ef4 in Discord, on why a peerDep vs a dep:

@ember/string contains shared module state (there are cache-based optimizations), which is one factor in trying to ensure a single copy.

It's not wrong for some addons to decide they'd rather use it as a dependency than a peerDependency, but it invites duplication, and in the case of @ember/string you'll also duplicate the caches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants