[WIP]: Prepare fastboot addon for Fasboot 1.0 release#288
Closed
kratiahuja wants to merge 2 commits intoember-fastboot:masterfrom
kratiahuja:build-refactor
Closed
[WIP]: Prepare fastboot addon for Fasboot 1.0 release#288kratiahuja wants to merge 2 commits intoember-fastboot:masterfrom kratiahuja:build-refactor
kratiahuja wants to merge 2 commits intoember-fastboot:masterfrom
kratiahuja:build-refactor
Conversation
This PR primarily addresses the following issues: 1. Double fastboot builds [issue](#264). Corresponding ember-cli changes are in this [PR](ember-cli/ember-cli#6395) 2. Removes the monkey patching introduced with fastboot build. Related [issue](#276) 3. Updates generated package.json to take in an array of app files (containing app.js and app-fastboot.js). Addresses this [issue](#270) Once the ember-cli [PR](ember-cli/ember-cli#6395) and this [issue](#274) is fixed, we can kill the `ember fastboot` command itself.
Contributor
Author
|
Here is a gist of how this can run with fastboot currently. |
ryanone
reviewed
Nov 11, 2016
| var patchEmberApp = require('./lib/ext/patch-ember-app'); | ||
| var fastbootAppModule = require('./lib/utilities/fastboot-app-module'); | ||
|
|
||
| var filterInitializers = require('fastboot-filter-initializers'); |
Contributor
There was a problem hiding this comment.
Is this dependency needed still?
Contributor
Author
There was a problem hiding this comment.
Nope, this was the dirty ember-app private patching that we was causing issues and perf problems.
Contributor
There was a problem hiding this comment.
I was actually referring to fastboot-filter-initializers :)
Contributor
Author
There was a problem hiding this comment.
Aah no i need to remove that.
Contributor
Author
|
Going to close this since there is no clear decision yet on how we want to approach the build problem. We can reopen this whenever a decision is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to unblock Fastboot 1.0 release, we want to make the fastboot build performant. We will achieve this by creating additive assets (see this issue for details). This PR primarily addresses some of the work already.
This PR primarily addresses the following issues:
TODO:
ember-serve. Corresponding issue.ember fastbootcommandcc: @tomdale @stefanpenner @rwjblue @kellyselden @ryanone @danmcclain @arjansingh @ryanone @masonwan @kristoferbaxter