[WIP]: Prepare for Fastboot lib for Fastboot 1.0 release#97
Closed
kratiahuja wants to merge 1 commit intoember-fastboot:masterfrom
Closed
[WIP]: Prepare for Fastboot lib for Fastboot 1.0 release#97kratiahuja wants to merge 1 commit intoember-fastboot:masterfrom
kratiahuja wants to merge 1 commit intoember-fastboot:masterfrom
Conversation
This PR primarily addresses the last chunk of issue of incorporating ember-cli changes to building performant fastboot assets. It primarily does the following: - package.json manifest now has an array of appFilesPath containing the app.js and app-fastboot.js Once the ember-cli [PR](ember-cli/ember-cli#6395) lands, this need to PR needs to be updated to fix the breaking tests.
12 tasks
rwjblue
reviewed
Nov 10, 2016
| let config = this.readPackageJSON(distPath); | ||
|
|
||
| this.appFilePath = config.appFile; | ||
| this.appFilesPath = config.appFiles; |
Member
There was a problem hiding this comment.
Small nit-pick, I'd prefer this.appFilePaths vs this.appFilesPath, what do you think?
Contributor
Author
There was a problem hiding this comment.
I am fine with any name 😄 I'll switch to the other name in my next push.
Contributor
Author
|
Here is a gist of how this can be tested. |
Contributor
Author
|
Going to close this since there is no clear decision yet on how we want to approach the build problem. We can reopen this whenever a decision is made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily addresses the last chunk of issue of incorporating ember-cli changes and ember-cli RFC to building performant fastboot assets. It primarily does the following:
TODO:
appFillesPathbackward compatiblecc: @tomdale @rwjblue @danmcclain @arjansingh @ryanone @masonwan @kristoferbaxter