Update README with new updateFastBootManifest hook#376
Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom Apr 23, 2017
kratiahuja:update-readme
Merged
Update README with new updateFastBootManifest hook#376rwjblue merged 1 commit intoember-fastboot:masterfrom kratiahuja:update-readme
updateFastBootManifest hook#376rwjblue merged 1 commit intoember-fastboot:masterfrom
kratiahuja:update-readme
Conversation
Member
|
Changes look good, pending beta release for merging... |
Contributor
Author
|
Thank you @rwjblue ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added
updateFastBootManifestin this PR. Updating the README to call out the same as well. Also took the liberty to make soft announcement on the upcoming deprecation.I can't word things very descriptively so definitely looking for feedback on how we should present the new API and upcoming deprecation (in a soft way first)
This should be merged in just before cutting the next beta if possible (cc: @danmcclain )
cc: @rwjblue @tomdale @simonihmig