Fix beta checks correctly by using gt API#378
Fix beta checks correctly by using gt API#378rwjblue merged 1 commit intoember-fastboot:masterfrom kratiahuja:fix-version-checker
gt API#378Conversation
|
Travis is failing. Not sure why. Will need to dig into this. |
|
Ya, satisfies is trying to be "safe" with prerelease versions. |
|
@rwjblue I forgot that this PR will introduce a minor regression. Earlier we allowed Is it possible to do a new release of |
|
Ya, I can for sure, but you can also switch to beta.0 or alpha.0 for now... |
|
Ohoo yeah I didn't realize that 😄 |
Apparently `satisfies` does not conform to beta channel checks correctly.
```js
> semver.satisfies('2.13.0-beta.1', '>=2.12.0-beta.1')
false
> semver.gt('2.13.0-beta.1', '2.12.0-beta.1')
true
```
|
@rwjblue This is good to merge. Travis is 💚 now. Thanks for your suggestion! 😄 |
|
@kratiahuja I just published ember-cli-version-checker |
|
@danmcclain - have time to release? |
|
@rwjblue I can tonight |
|
@danmcclain whenever you release, can you merge this one as well before releasing? #376 |
|
Published v1.0.0-beta.18 |
Apparently
satisfiesdoes not conform to beta channel checks correctly.cc: @rwjblue @danmcclain