Skip to content

[cleanup]: class based fastboot service#856

Closed
snewcomer wants to merge 16 commits intoember-fastboot:masterfrom
snewcomer:sn/inject-remove
Closed

[cleanup]: class based fastboot service#856
snewcomer wants to merge 16 commits intoember-fastboot:masterfrom
snewcomer:sn/inject-remove

Conversation

@snewcomer
Copy link
Contributor

@snewcomer snewcomer commented Sep 10, 2021

This PR just seeks to cleanup some code and deprecations

close #815

@ef4
Copy link
Contributor

ef4 commented Sep 10, 2021

👍

I'm not sure what the support matrix is between fastboot and ember-cli-fastboot but this change means fastboot will be dropping support for ember-cli-fastboot prior to #841.

@snewcomer
Copy link
Contributor Author

snewcomer commented Sep 10, 2021

Actually we could go about it another way. When I originally did the PR, this was one of the test cases. We need to add a setter for it to not raise a deprecation.

https://github.com/emberjs/ember.js/pull/19358/files#diff-2600f49bdcd760f57af70712f38930aca2c85c30752165032d9998359ed9109dR265-R295

@snewcomer snewcomer changed the title Avoid implicit injection _fastbootInfo deprecation pt 2 [cleanup]: class fast boot service Sep 13, 2021
@snewcomer
Copy link
Contributor Author

snewcomer commented Sep 13, 2021

@ef4 I've changed the scope of this PR and opened a new PR with the actual fix that works - #857.

change means fastboot will be dropping support for ember-cli-fastboot

However, all injections do need to be dropped for 4.0. From your point of view, what is the concern if we aren't injecting directly onto the fast boot service from ember-cli-fastboot?

Nvmd I see it. The fastboot package's files aren't directly available in ember-cli-fastboot anymore.

@snewcomer snewcomer changed the title [cleanup]: class fast boot service [cleanup]: class based fastboot service Sep 13, 2021
@snewcomer snewcomer force-pushed the sn/inject-remove branch 2 times, most recently from e21f0b3 to 5324dbb Compare September 13, 2021 03:52
@snewcomer snewcomer closed this May 8, 2022
@snewcomer snewcomer deleted the sn/inject-remove branch May 8, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update "fastboot" service to use native classes

2 participants