Avoid implicit injection _fastbootInfo deprecation pt 2#857
Merged
mansona merged 2 commits intoember-fastboot:masterfrom Sep 14, 2021
Merged
Avoid implicit injection _fastbootInfo deprecation pt 2#857mansona merged 2 commits intoember-fastboot:masterfrom
mansona merged 2 commits intoember-fastboot:masterfrom
Conversation
snewcomer
force-pushed
the
sn/fix-implicit-injection-set
branch
from
689a32b to
9050432
Compare
mansona
approved these changes
Sep 14, 2021
Contributor
|
Looks like it's still an issue - #869 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually fixes #841.
Note: this way this works is if there is a setter (not just a getter), then it overrides and doesn't issue the deprecation.
https://github.com/emberjs/ember.js/pull/19358/files#diff-2600f49bdcd760f57af70712f38930aca2c85c30752165032d9998359ed9109dR265-R295