Add ember-try testing for ember-cli-fastboot#858
Merged
Conversation
mansona
force-pushed
the
add-ember-try
branch
3 times, most recently
from
888293e to
9f53b2a
Compare
mansona
force-pushed
the
add-ember-try
branch
from
9f53b2a to
ff214f5
Compare
xg-wang
approved these changes
Sep 14, 2021
kiwiupover
approved these changes
Oct 6, 2021
Contributor
|
anything keeping this from being merged? it'd be a requirement for further updating for ember 4 support (require ember-auto-import@v2) |
kiwiupover
approved these changes
Oct 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also adding some "no-deprecations" tests so that hopefully we can see that #857 will actually fix things objectively 😂
Edit: this looks like it's doing its job. The no-deprecations (and the beta/canary builds) are failing because of the deprecation that people are reporting.
I'm personally not sure what the value is to having all of the ember-try scenarios that this PR defines 🤔 but I think that we could potentially combine this PR with #857 and get a better feel if we've caught all of the places that show the deprecation 👍