fix(quick-start): use props instead of args in route template code example#1065
Closed
jayjayjpg wants to merge 1 commit intoember-learn:octanefrom
Closed
fix(quick-start): use props instead of args in route template code example#1065jayjayjpg wants to merge 1 commit intoember-learn:octanefrom
jayjayjpg wants to merge 1 commit intoember-learn:octanefrom
Conversation
Contributor
|
This was an intentional change (#1044), part of emberjs/rfcs#523. As of emberjs/ember.js#18363, |
Contributor
Author
|
@chancancode Thanks a lot for the detailed explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the code example in the Quick Start section, explaining how to pass properties to a component to use the
this.syntax instead of argument syntax@.As far as I'm aware, properties are only prefixed with an
@when they refer to arguments passed into a component. In this code example the propertymodelis used in a route's template though, thereforethis.modelshould be used instead of@model.