[FEATURE ember-routing-model-arg] Enable by default.#18363
Merged
rwjblue merged 2 commits intoemberjs:masterfrom Sep 6, 2019
Merged
[FEATURE ember-routing-model-arg] Enable by default.#18363rwjblue merged 2 commits intoemberjs:masterfrom
rwjblue merged 2 commits intoemberjs:masterfrom
Conversation
Contributor
|
Do we need to update any API docs along with enabling this? |
rwjblue
force-pushed
the
enable-model-arg
branch
from
b47a8fe to
5cb7c11
Compare
Member
Author
|
@pzuraq - Yes, @chancancode is working up a docs specific PR for this now. Going to merge, so we can do a bit more testing but that PR should be up soon. |
chancancode
added a commit
that referenced
this pull request
Sep 7, 2019
This is maybe part of #18363? The `{{#each}}` docs is the only instance in the API docs where we reference a `model` property. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block. I also tried to make the `key` documentation a little more clear.
chancancode
added a commit
to ember-learn/guides-source
that referenced
this pull request
Sep 7, 2019
wycats
pushed a commit
that referenced
this pull request
Sep 7, 2019
This is maybe part of #18363? The `{{#each}}` docs is the only instance in the API docs where we reference a `model` property. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block. I also tried to make the `key` documentation a little more clear.
wycats
pushed a commit
that referenced
this pull request
Sep 7, 2019
This is maybe part of #18363? The `{{#each}}` docs is the only instance in the API docs where we reference a `model` property. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block. I also tried to make the `key` documentation a little more clear.
chancancode
added a commit
to ember-learn/guides-source
that referenced
this pull request
Sep 7, 2019
chancancode
added a commit
to ember-learn/guides-source
that referenced
this pull request
Sep 7, 2019
wycats
pushed a commit
that referenced
this pull request
Sep 18, 2019
This is maybe part of #18363? The `{{#each}}` docs is the only instance in the API docs where we reference a `model` property. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block. I also tried to make the `key` documentation a little more clear. (cherry picked from commit 63bf203)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in todays team meeting.