[DOC] Minor fixes for {{#each}} and {{#each-in}}#18364
Merged
Conversation
wycats
force-pushed
the
chancancode-patch-1
branch
from
e3b11b7 to
f95c84e
Compare
This is maybe part of #18363? The `{{#each}}` docs is the only instance in the API docs where we reference a `model` property. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block. I also tried to make the `key` documentation a little more clear.
wycats
force-pushed
the
chancancode-patch-1
branch
from
f95c84e to
63bf203
Compare
rwjblue
approved these changes
Sep 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is maybe part of #18363?
The
{{#each}}docs is the only instance in the API docs where we reference amodelproperty. It's not even clear if this is referring to the controller's property, but since it's just an arbitrary name for illustration purposes, I just changed it to match the rest of the examples given in the same block.I also tried to make the
keydocumentation a little more clear.Since this is not directly coupled to #18363, this can be backported to beta.