Conversation
Contributor
|
Note that we will need to take care of a couple odds and ends before we turn on Continuous Deployment. Good to see that merging !== CD right away. |
Member
|
can you clarify what this is combining? I have strong objections to merging the guides-source and guides-app- for maintenance reasons, I think it's strategically important for us to separate the content from the presentation layer. |
MelSumner
approved these changes
Jan 30, 2019
Member
|
@mansona looks like there's some conflicts to resolve first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves us into a "single repo" mode just like the new Ember Cli Guides project. This has a number of benefits over the two repo process we have been doing for the last year:
It's also worth noting that merging this doesn't make it go live right away. I wouldn't merge this PR unless we have decided that we intended to go live realatively soon, but we have time to figure things out for a little while before going live.