Skip to content

update ember inspector screenshots for tackling deprecations (#314)#373

Merged
locks merged 2 commits intoember-learn:masterfrom
dbendaou:update/ember_inspector_tackling_deprecations
Jan 30, 2019
Merged

update ember inspector screenshots for tackling deprecations (#314)#373
locks merged 2 commits intoember-learn:masterfrom
dbendaou:update/ember_inspector_tackling_deprecations

Conversation

@dbendaou
Copy link
Contributor

@dbendaou dbendaou commented Jan 29, 2019

This PR update ember-inspector/tackling-deprecations pictures

I don't understand why the deploy is falling.. This is my first PR btw so some help would be appreciate 🤓

Closes #314

@dbendaou
Copy link
Contributor Author

capture d ecran 2019-01-29 a 23 06 40

capture d ecran 2019-01-29 a 23 06 49

@locks
Copy link
Contributor

locks commented Jan 30, 2019

Thanks for the help @dbendaou. The deploy is currenty failing because we are in the middle of restructuring the repository (see #365), so it's definitely not your fault!

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👌

@dbendaou
Copy link
Contributor Author

Cool thanks 👍

@locks locks merged commit a02a329 into ember-learn:master Jan 30, 2019
@locks
Copy link
Contributor

locks commented Jan 30, 2019

Congrats on your first guides-source PR 😁 Keep'em coming!
Drop by our Discord (link at https://emberjs.com/community/) if you want to discuss anything with the learning team or join in our weekly Thursday team call.

@dbendaou
Copy link
Contributor Author

Would be a pleasure 🤗

@dbendaou dbendaou deleted the update/ember_inspector_tackling_deprecations branch January 30, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants