Merged
Conversation
BlueCutOfficial
force-pushed
the
vite-support
branch
from
dfacb9a to
a358ca1
Compare
patricklx
reviewed
Jul 9, 2025
BlueCutOfficial
force-pushed
the
vite-support
branch
from
a358ca1 to
40c998b
Compare
Contributor
|
Rebased on #2668: since |
BlueCutOfficial
force-pushed
the
vite-support
branch
2 times, most recently
from
c82e465 to
c757db7
Compare
BlueCutOfficial
force-pushed
the
vite-support
branch
from
c757db7 to
a3f19ff
Compare
|
|
||
| let self = this; | ||
| // maintaining `baseURL` for backwards compatibility. See: http://emberjs.com/blog/2016/04/28/baseURL.html | ||
| - let baseURL = options.liveReloadBaseUrl || options.rootURL || options.baseURL; |
Contributor
There was a problem hiding this comment.
do we need to ship this change in this package?
Member
Author
There was a problem hiding this comment.
so this is something that we should ship upstream but for now this just unblocks local development
| import Port from 'ember-debug/port'; | ||
| import setupEmberDebugTest from '../helpers/setup-ember-debug-test'; | ||
|
|
||
| // import PortImport from 'ember-debug/port'; |
NullVoxPopuli
approved these changes
Oct 1, 2025
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
I'm happy with signing off on this. If anything comes up (if I need to), I'm happy to fix things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalises a lot of work done to get the Ember Inspector to support Vite 🎉 This will require a global API that Embroider can polyfill after this PR is merged: embroider-build/embroider#2522
There will be a follow up RFC that will move this polyfill implementation into ember-source 👍