Merged
Conversation
BlueCutOfficial
force-pushed
the
cleanup-import-ember
branch
2 times, most recently
from
3a7f7ba to
34cbf29
Compare
BlueCutOfficial
force-pushed
the
cleanup-import-ember
branch
from
34cbf29 to
a33becf
Compare
Contributor
Author
|
I tried to remove the |
Merged
mansona
approved these changes
Jul 11, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
This is a good PR, I've added one comment/question but I don't consider it a blocker
BlueCutOfficial
force-pushed
the
cleanup-import-ember
branch
from
a33becf to
355b3ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of preparing the ground for Vite support. When running the Inspector against a Vite app, the
Emberglobal fromember_debug/utils/emberis undefined. The problem is twofold: first, the utils file itself is not prepared for this case; second, Ember is exported as default from the utils to be used in different places of the code.This PR:
import Ember from 'ember_debug/utils/ember'in favor of the named exports.Emberproperties ifEmberis not defined.