Conversation
The code paths inside Application.init, within the ember-application-visit flag are never hit by any of the tests. Furthermore, autoboot must be explicitly set to false when running in node to allow passing in a url when booting an app instance. Thus, make it default to false when in node, true when in the browser, to abstract this concern away from the user.
There was a problem hiding this comment.
is regression b/c ?
also, although need to run and make sample app to show it, should work with the following commits to the officially supported ember fastboot build and server repos: - https://github.com/eriktrom/ember-cli-fastboot/tree/one-build - https://github.com/eriktrom/ember-fastboot-server/tree/one-build
|
@tomdale - as of last commit, this works fully here's the benefit, from your build and server repos: eriktrom/ember-cli-fastboot@master...one-build i know it would sure make my build similarly simpler as well. also seems to make fastboot officially supported build being more prone to being agnostic to backend server framework (at some point) and even makes it easier to separate your fastboot server repo from ember cli as well (cause now our builds look almost the same, and im not using ember cli middleware at all, using hapi). let me know of your interest level and i'll make a sample app to prove this works with your repos (the code in those links i haven't actually ran yet :P, but works on my setup, they are very similar now) note that the incrementAutoboot flag in the last commit would be temporary, its just there for the tests that i think need some more thought, 10 or 11 of them testing that you can set the autoboot setting to false is what that hack is (still far less than the build setup though if we're counting) failure for ci is saucelabs - seems stuck today in any case, i had fun and learned a lot so we can close and re-visit later, no biggie, i know we never talked about this, it was just annoying me :) caveats - none, you can still set the autoboot flag from Ember.Application namespace, when calling create, but doing so requires leaving some form of the incrementAutoboot method in place - although i'd be willing to bet there is a much cleaner way if we decide to continue with this thought process, which in general should clean things up that seem hacky/cruft as they are EDIT: 1 time for grammar and caveats |
eriktrom
changed the title
|
☔ The latest upstream changes (presumably #13100) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@homu - I was actually thinking this should be closed - never heard back and while I like the idea, the problem I was trying to solve can be solved other ways, this was my first learning experience with node on the server - so will close for now, ping me if there is interest in re-opening |
2 participants
Make autoboot setting actually automatic
cc @tomdale @chancancode