Removed ember-application-visit feature guards

[shashwat91]

All the instances and feature guards of 'ember-application-visit' are removed as stated in issue #13088.

We are group of developers working started working on ember.js and we wanted to contribute something to the project. Thanks @chancancode for marking his issue as 'good for new contributors'.

[homu]

☔ The latest upstream changes (presumably #13096) made this pull request unmergeable. Please resolve the merge conflicts.

[chancancode]

This should be removed

[chancancode]

Left some line comments. After resolving them, can you squash your commits and rebase against master? Thank you!

[andrewflash]

@chancancode, you said that we can just merge this into the actual class definition instead of reopening the class. How can I do that? and I still get some errors in Travis CI. Any solution? Thank you.

[chancancode]

This should not be removed

[andrewflash]

I got an error when I keep that line, application is declared but never used.

[chancancode]

👍

[chancancode]

you said that we can just merge this into the actual class definition instead of reopening the class. How can I do that?

Instead of..

const Application = Engine.extend({

  init: ...,

  ...

});

...

Application.reopen({

  visit: ...

});

...

It could just be...

const Application = Engine.extend({

  init: ...,

  ...,

  visit: ...

});

...

...

[shashwat91]

@chancancode thanks for feedback. We are now working on it.

[chancancode]

ApplicationInstance.reopen can probably be merged too

[sambit2]

@chancancode Thank you for your help as we are new into this. @andrewflash Good job

[chancancode]

Thanks! 👍