[GLIMMER2] Migrate {{render}} tests#13681
Merged
rwjblue merged 1 commit intoemberjs:masterfrom Jun 16, 2016
Merged
Conversation
chadhietala
changed the title
Contributor
|
☔ The latest upstream changes (presumably #13658) made this pull request unmergeable. Please resolve the merge conflicts. |
chadhietala
force-pushed
the
migrate-render-tests
branch
from
50e1574 to
3b9c195
Compare
chadhietala
force-pushed
the
migrate-render-tests
branch
from
3b9c195 to
0e25c9f
Compare
| equal(view.$().text(), 'HIBYE'); | ||
| // This is a poor assertion. What is really being tested is that | ||
| // a second render with the same name will throw an assert. | ||
| ok(appInstance.lookup('router:main')._lookupActiveComponentNode('home'), 'should register home as active view'); |
Contributor
Author
There was a problem hiding this comment.
This just seems wrong so I removed it.
chadhietala
changed the title
| this.assertText('HIFOOBARBAZ'); | ||
| } | ||
|
|
||
| ['@test should have assertion if neither template nor view exists']() { |
Member
There was a problem hiding this comment.
Can you tweak this title and remove view (we don't support the view part anymore and I think I missed it when I updated te original test)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates the
{{render}}tests to the new test infra. It also removes these tests dependency on the hardcodedInteractiveRendererin CoreView.Ported, consolidated, and removed tests are annotated below.
Part of #13644